List:Commits« Previous MessageNext Message »
From:Mike Lischke Date:April 18 2011 1:36pm
Subject:bzr commit into wex-installer-1.0 branch (mike.lischke:439)
View as plain text  
#At file:///D:/Work/MySQL/installer/ based on revid:mike.lischke@stripped

  439 Mike Lischke	2011-04-18
      Product: for pure feature changes we don't need to check the upgrade code (and hence do a removal followed by an installation if that is empty).

    modified:
      WexInstaller.Core/Product.cs
=== modified file 'WexInstaller.Core/Product.cs'
=== modified file 'WexInstaller.Core/Product.cs'
--- a/WexInstaller.Core/Product.cs	2011-04-18 13:14:52 +0000
+++ b/WexInstaller.Core/Product.cs	2011-04-18 13:36:47 +0000
@@ -738,7 +738,7 @@
           // Upgrade only if there is a related product which we actually can upgrade.
           if (CurrentState == ProductState.WillPerformUpgrade || Installed)
           {
-            if (string.IsNullOrEmpty(UpgradeId))
+            if ((CurrentState == ProductState.WillPerformUpgrade) && string.IsNullOrEmpty(UpgradeId))
               type = ChangeType.InstallFollowingRemove;
             else
               type = ChangeType.Update;


Attachment: [text/bzr-bundle] bzr/mike.lischke@oracle.com-20110418133647-ujtee26hpt9hehai.bundle
Thread
bzr commit into wex-installer-1.0 branch (mike.lischke:439) Mike Lischke18 Apr