List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:April 14 2011 1:02pm
Subject:Re: [Resend] bzr commit into mysql-trunk branch (guilhem.bichot:3290)
View as plain text  
Hello,

Jorgen Loland a écrit, Le 14.04.2011 13:53:
> Guilhem,
> 
> Excellent patch! Two comments:

thanks!

>  > === modified file 'sql/opt_trace.cc'
>  > --- sql/opt_trace.cc    2011-04-05 07:34:13 +0000
>  > +++ sql/opt_trace.cc    2011-04-12 13:40:12 +0000
>  > @@ -75,15 +75,18 @@
>  >       may have been written to, will likely be invalid JSON.
>  >    */
>  >    bool open_struct(const char *key, Opt_trace_struct *ots,
>  > -                   Opt_trace_context::feature_value feature,
>  > -                   char opening_bracket);
>  > +                   bool has_disabled_I_S, char opening_bracket);
> 
> Update documentation for this method

fixed

>  > @@ -1038,6 +1052,14 @@
>  >    */
>  >    char previous_key[25];
>  >  #endif
>  > +
>  > +  /**
>  > +    Whether this structure caused tracing to be disabled in this 
> statement
>  > +    because belonging to a not-traced optimizer feature, in 
> accordance with
>  > +    the value of @@@@optimizer_trace_features.
>  > +  */
>  > +  bool has_disabled_I_S;
>  > +  bool empty;                                   ///< @see is_empty()
> 
> You probably mean "set_not_empty()"

yes, fixed
Thread
[Resend] bzr commit into mysql-trunk branch (guilhem.bichot:3290) Guilhem Bichot13 Apr
  • Re: [Resend] bzr commit into mysql-trunk branch (guilhem.bichot:3290)Jorgen Loland14 Apr
    • Re: [Resend] bzr commit into mysql-trunk branch (guilhem.bichot:3290)Guilhem Bichot14 Apr