On 04/14/11 10:54 AM, Sergey Glukhov wrote:
> On 04/14/2011 12:38 PM, Bjorn Munch wrote:
>> On 14/04 08.11, Sergey Glukhov wrote:
>>> === modified file 'mysql-test/t/analyse.test'
>>> --- a/mysql-test/t/analyse.test 2011-03-14 18:03:22 +0000
>>> +++ b/mysql-test/t/analyse.test 2011-04-14 08:11:57 +0000
>>> @@ -1,6 +1,7 @@
>>> # Test of procedure analyse
>>> +-- source include/have_innodb.inc
>> But this means the rest of the existing analyse.test will no longer be
>> run without innodb. Maybe not a big deal (and not a problem for 5.5),
>> but I still think it's bad to disable an existing test for myisam in
>> this way.
> imho it' a big problem,
> we already have 54 tests with
> 'have_innodb' in main suite.
Many of these tests only contain test cases for InnoDB relevant bugs,
while general test cases have been put into a more general test. Here
you are limiting a general tests to when InnoDB is available.
However, I still does not think this is a big issue since starting with
5.5, InnoDB shouild always be present, so the test will always be run.
Maybe we could just drop the have_innodb inclusion going forward?