List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:April 6 2011 1:33pm
Subject:bzr commit into mysql-trunk branch (alfranio.correia:3333) Bug#12324076
View as plain text  
#At file:///home/acorreia/workspace.oracle/repository.mysql/bzrwork/tmp/mysql-trunk/ based on revid:georgi.kodinov@stripped

 3333 Alfranio Correia	2011-04-06
      BUG#12324076 - RQG_RPL_SEMISYNC TEST FAILURE, SLAVE CRASHES WITH SEGMENTATION FAULT
      
      The patch for BUG#11765887 BUG#58897 verifies if the configuration is not
      crash-safe and prints out a warning message to alert users on that.
      
      The routine that keeps track of warnings and errors on the slave was modified
      in BUG#11748510 - BUG#36524 and after that report_function may be null if
      global_system_variables.log_warnings is not set. However, report_function is
      used without checking its value thus causing a crash.
      
      Fixed the problem, by checking if report_function is null before using it.

    modified:
      sql/rpl_reporting.cc
=== modified file 'sql/rpl_reporting.cc'
--- a/sql/rpl_reporting.cc	2011-03-28 13:19:08 +0000
+++ b/sql/rpl_reporting.cc	2011-04-06 13:33:37 +0000
@@ -149,10 +149,11 @@ Slave_reporting_capability::report(logle
   va_end(args);
 
   /* If the msg string ends with '.', do not add a ',' it would be ugly */
-  report_function("Slave %s: %s%s Error_code: %d",
-                  m_thread_name, pbuff,
-                  (pbuff[0] && *(strend(pbuff)-1) == '.') ? "" : ",",
-                  err_code);
+  if (report_function)
+    report_function("Slave %s: %s%s Error_code: %d",
+                    m_thread_name, pbuff,
+                    (pbuff[0] && *(strend(pbuff)-1) == '.') ? "" : ",",
+                    err_code);
 #endif  
 }
 


Attachment: [text/bzr-bundle] bzr/alfranio.correia@oracle.com-20110406133337-kfz587gzza336qx3.bundle
Thread
bzr commit into mysql-trunk branch (alfranio.correia:3333) Bug#12324076Alfranio Correia6 Apr