On 05/04/11 17:46, Alexander Nozdrin wrote:
> #At file:///home/alik/MySQL/bzr/00/bug12325375/mysql-5.5-bug12325375/ based on
> revid:georgi.kodinov@stripped
>
> 3421 Alexander Nozdrin 2011-04-05
> A patch for Bug#12325375: THE SERVER ON WINXP DOES NOT ALLOW CONNECTIONS
> IF NO DNS-SERVER AVAILABLE.
Looking good. Just two small issues.. :)
> modified:
> include/violite.h
> sql/hostname.cc
> vio/viosocket.c
Update copyright headers in these :)
> === modified file 'vio/viosocket.c'
> --- a/vio/viosocket.c 2010-08-16 12:50:27 +0000
> +++ b/vio/viosocket.c 2011-04-05 15:46:41 +0000
> @@ -1060,6 +1060,34 @@ ssize_t vio_pending(Vio *vio)
>
>
> /**
> + Checks if the error code, returned by vio_getnameinfo(), means it was the
> + "No-name" error.
> +
> + Windows-specific note: getnameinfo() returns WSANO_DATA instead of
> + EAI_NODATA or EAI_NONAME when no reverse mapping is available at the host
> + (i.e. Windows can't get hostname by IP-address). This error should be
> + treated as EAI_NONAME.
> +
> + @return if the error code is actually EAI_NONAME.
> + @retval true if the error code is EAI_NONAME.
> + @retval false otherwise.
> +*/
> +
> +my_bool vio_is_no_name_error(int err_code)
> +{
> +#ifdef __WIN__
Use _WIN32 instead of __WIN__
(we're phasing out all these different Win-symbols, and standardizing
on _WIN32, as this is the one preferred by Microsoft)
From http://msdn.microsoft.com/en-us/library/b0084kay.aspx:
_WIN32 Defined for applications for Win32 and Win64. Always defined.
Ok to push!
--Magne
