List:Commits« Previous MessageNext Message »
From:Magne Mæhre Date:April 4 2011 1:06pm
Subject:Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3329) WL#5787
View as plain text  
On 29/03/11 15:25, Alexander Nozdrin wrote:
> #At file:///home/alik/MySQL/bzr/00/wl5787/mysql-trunk-wl5787/ based on
> revid:sven.sandberg@stripped
> 
>  3329 Alexander Nozdrin	2011-03-29
>       Preliminatry patch for WL#5787 (IPv6-capable INET_ATON and
>       INET_NTOA functions).
>       

Hi Alik
This looks mostly good, but there is an MS Windows related issue


> === added file 'sql/item_inetfunc.cc'
> +
> +#include <sys/socket.h>

Doesn't exist in MS Windows

> +#include <netinet/in.h>

Doesn't exist in MS Windows

> +#include <netdb.h>

Doesn't exist in MS Windows


IIRC, my_global.h includes the correct headers


Review for the "real" WL#5787 is coming real-soon-now :)

--Magne
Thread
bzr commit into mysql-trunk branch (alexander.nozdrin:3329) WL#5787Alexander Nozdrin29 Mar
  • Re: bzr commit into mysql-trunk branch (alexander.nozdrin:3329) WL#5787Magne Mæhre4 Apr