List:Commits« Previous MessageNext Message »
From:Olav Sandstaa Date:April 1 2011 9:51am
Subject:Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131
View as plain text  
On 03/28/2011 02:52 PM, Tor Didriksen wrote:
>
>>> -  bool     asc;                /* true if ascending */
>>> +  enum enum_order {
>>> +    ORDER_NOT_RELEVANT,
>>> +    ORDER_ASC,
>>> +    ORDER_DESC
>>> +  };
>>> +
>>> +  enum_order order;                     /* Requested direction of
> ordering */
>
> Please align comments.
> What happens if we have NOT_RELEVANT here?
> Maybe asc_or_desc is a better name, compare:
>    order->order= ...;
> with
>    order->asc_or_desc= ....;
>

I have no strong opinions about the name but I think keeping "order" as 
the name is fine. A third alternative could be "sort_order"?

Olav
Thread
bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Jorgen Loland28 Mar
  • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Tor Didriksen28 Mar
    • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Olav Sandstaa1 Apr
    • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Jorgen Loland1 Apr
  • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Olav Sandstaa1 Apr
    • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Jorgen Loland1 Apr
      • Re: bzr commit into mysql-5.5 branch (jorgen.loland:3404) Bug#11882131Olav Sandstaa1 Apr