From: Andrei Elkin
Date: March 26 2011 11:05am
Subject: bzr commit into mysql-trunk branch (andrei.elkin:3327) Bug#11763265
List-Archive: http://lists.mysql.com/commits/133937
X-Bug: 11763265
Message-Id: <201103261105.p2QB5j4e028095@mysql1000.dsl.inet.fi>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1993970383=="

--===============1993970383==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///home/andrei/MySQL/BZR/2a-23May/FIXES/bug11763265-55956-mysqlbinlog_raw_mode/ based on revid:georgi.kodinov@stripped

 3327 Andrei Elkin	2011-03-26
      bug#11763265 Potential bug with new --raw mode with mysqlbinlog
      
      There are two reported artifacts on possible operations with uninitialazed Log_event* pointer
      inside dump_remote_log_entries().
      In fact, under --raw mode only Load-data events generated by pre 5.0.3 servers is the valid issue.
      That relates to the assignment Load_log_event *le= (Load_log_event*)ev
      where rhs is not initialized when --raw.
      Rotate event is indeed handled correctly.
      
      Fixed making LOAD_EVENT to be dumped as raw_mode is supposed to do without instantiation of
      the event.
      Also as CREATE_FILE_EVENT infers binlog_version >= 3 the event type is removed out of the
      problematic if clause.

    modified:
      client/mysqlbinlog.cc
=== modified file 'client/mysqlbinlog.cc'
--- a/client/mysqlbinlog.cc	2011-01-18 12:09:03 +0000
+++ b/client/mysqlbinlog.cc	2011-03-26 11:05:39 +0000
@@ -1674,7 +1674,7 @@ static Exit_status dump_remote_log_entri
       ev->register_temp_buf((char *) net->read_pos + 1);
     }
     if (glob_description_event->binlog_version >= 3 ||
-        (type != LOAD_EVENT && type != CREATE_FILE_EVENT))
+        (type != LOAD_EVENT || raw_mode))
     {
       /*
         If this is a Rotate event, maybe it's the end of the requested binlog;


--===============1993970383==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/andrei.elkin@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: andrei.elkin@stripped
# target_branch: file:///home/andrei/MySQL/BZR/2a-23May/FIXES\
#   /bug11763265-55956-mysqlbinlog_raw_mode/
# testament_sha1: 9a45c666441a2fffa17b7f9adb63462071c60089
# timestamp: 2011-03-26 13:05:45 +0200
# base_revision_id: georgi.kodinov@stripped\
#   lw2g411ffimrgmtt
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWb0yqfEAAbJfgEQQeHf/938l
1QC////0UATmvHRXdqNsADohoQTSbSepMZCejUYINAMQbSDZEBoplTaenqYFT2ptUyaAAGIDQaAD
QamTSepop4FD1PSYjQyeiGmQekzSAxA5gEwEyMAIxMTCYTBDTE0wEkQImCGk9GhNNTCanqeg1Gaa
mTQ0GSdcutWN51ehYZgHI1T1kZAHPiNSfUStj9tdwmMzP4WrPvD8dJmYVUUS3Z0GiR6MYxwrjoj5
Sc88qUGiR/i8BrYQ3yp9RvXjI7pGGoJBUPnmJI1NQta2LxL/POdRF4I0UuRJpUidqgph4GxupyxX
7lCsdBIZCSSMdenPDViviIzKa4KwQjz9xpGFxjat5ln7VuJ6+rEutzNqikdgjd0arZa4i7W8PWeF
pIcRm5n40fSoiDbmnqqOpQX2seWdL1Rl20KeTjoIsL4+JjumIwE3lveU7VdGkNt2wldiexYcSP7b
bhkUxAKQUPqfeFB1GxF1h3rFZbWI8iAgtmNtKJFujTUErC86lbnjlKpjSMg2kD2mBfAZXx0JTkdt
BsjAhFV8VCEuLq1vErcsxMyo4/5ZS7AxmuV4tj5ctkdElZE0mdpSo7j7wjbQuFjhMnEr5baaVRjI
TCNZbypjAUhfhF27ODBLWoQUT3klAxzkmTiOq26xkLC6slVdWYjC2RoUSoW8cqhicShrsMLDReQw
qMNEUrUnlbQw4QZhxsJSQPAgUpvIU+nrfjTLSZC9bFn77WOIuA+YanhDMzVHULGcS5FZVEqOs7Fg
VG8nBK28StoJh/o3wDHhqFvPkpemf1oRZw5eXgU9Ej2HkeicvLZAZtYzmLsGQ0DSD0WN9abpDmQC
3aPDE/YsQUowW1J9nuPL3hdImh679cxRc/QfSdYU8wpsMR/1uvPmqXfjhZY17pGupIpGPJj5jpUY
IQOx31c/oUmUtU1B9RGSrLmHyDdR7XlGuYqC7hcitfivSwFIwM59I+/X1NGGBwOAI0V1OAYsmM+S
6jpC2da3ngnKAkssz0nJYei31czsTTyPge4PNopgAKGrmPJuQNykV5BNPewGBSxN4fVBebQVE0cD
J9W+03eO2wlGl9jYH9YeoYYkF1FPrqbidusDgbt5bV6yOJ03yLF+fVXRaaQO80w7h01ycWkWpFKL
FXSE6v3Fq7DcFfptJIs90W742bFtA5qJ+RCEFJrWfLs8OSniKEZ01NsKaBd518VMZUgCY0vfDSLQ
pQ3+fLbK+1gaiOXAH7cwvOHpXkfX+hz28+I1150cKAdIdfDxXbjH1BdqCuCL5daJ8opD/ZsIzkxs
PjWlxxzDFMfLDl3KPV1pHPercJ1Yngc679AxWV4VjVr1qnngqpGj6Mh0mnogit9bJSpOaqo4EtEo
KDEwTNRgdgZd/Pp2HJuPYfRS3ZIrT3mYpsvfyBXkmDyd6O33SLw1LUqqyKY6f4w/GXjdNSMU0OTM
nOgahG+wfec39Vfxzpais4srEl3OdSsOyqJTPkBObRQzXXwLFqT102vJWQi8Ipmrd2T2T4ZQeEXU
8mc1xqmx7TEXV2HagC0KOXn4vQ8ZCMJIp0AHnHYXgOuVTQddLIdvQesm+ojDGMYTeGg1X2qC3M8q
qoDQrLxy6iuCYoTdblVPMXk+VcVgxziSJFt5sZRZxWprt37EA82qVyZV4sHbkl6xfD3uK/osVmGz
reDQPAsFCHZikhmEbrl/i7kinChIXplU+IA=


--===============1993970383==--