List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:March 26 2011 11:05am
Subject:bzr commit into mysql-trunk branch (andrei.elkin:3327) Bug#11763265
View as plain text  
#At file:///home/andrei/MySQL/BZR/2a-23May/FIXES/bug11763265-55956-mysqlbinlog_raw_mode/ based on revid:georgi.kodinov@stripped

 3327 Andrei Elkin	2011-03-26
      bug#11763265 Potential bug with new --raw mode with mysqlbinlog
      
      There are two reported artifacts on possible operations with uninitialazed Log_event* pointer
      inside dump_remote_log_entries().
      In fact, under --raw mode only Load-data events generated by pre 5.0.3 servers is the valid issue.
      That relates to the assignment Load_log_event *le= (Load_log_event*)ev
      where rhs is not initialized when --raw.
      Rotate event is indeed handled correctly.
      
      Fixed making LOAD_EVENT to be dumped as raw_mode is supposed to do without instantiation of
      the event.
      Also as CREATE_FILE_EVENT infers binlog_version >= 3 the event type is removed out of the
      problematic if clause.

    modified:
      client/mysqlbinlog.cc
=== modified file 'client/mysqlbinlog.cc'
--- a/client/mysqlbinlog.cc	2011-01-18 12:09:03 +0000
+++ b/client/mysqlbinlog.cc	2011-03-26 11:05:39 +0000
@@ -1674,7 +1674,7 @@ static Exit_status dump_remote_log_entri
       ev->register_temp_buf((char *) net->read_pos + 1);
     }
     if (glob_description_event->binlog_version >= 3 ||
-        (type != LOAD_EVENT && type != CREATE_FILE_EVENT))
+        (type != LOAD_EVENT || raw_mode))
     {
       /*
         If this is a Rotate event, maybe it's the end of the requested binlog;


Attachment: [text/bzr-bundle] bzr/andrei.elkin@oracle.com-20110326110539-dgdgiidf68btwwxd.bundle
Thread
bzr commit into mysql-trunk branch (andrei.elkin:3327) Bug#11763265Andrei Elkin26 Mar