List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:March 24 2011 7:19am
Subject:Re: bzr commit into mysql-5.5 branch (Georgi.Kodinov:3396)
Bug#11766306
View as plain text  
Hi Joro,

Ok to push. We all understand that have_innodb stays "YES" after
"UNINSTALL PLUGIN InnoDB". One small comment re test case inline.

On Wed, Mar 23, 2011 at 05:03:47PM -0000, Georgi Kodinov wrote:
> #At file:///Users/kgeorge/mysql/work/B11766306-5.5/ based on
> revid:bjorn.munch@stripped
> 
>  3396 Georgi Kodinov	2011-03-23
>       Bug #11766306: 59393: have_innodb=yes when mysqld started with --skip-innodb
>       
>       Initialized correctly the have_innodb variable so that when the plugin is not
> initialized it
>       stays "disabled" instead of "yes".
>       Test suite added.
> 
>     modified:
>       mysql-test/r/bootstrap.result
>       mysql-test/t/bootstrap.test
>       sql/sys_vars.cc
> === modified file 'mysql-test/r/bootstrap.result'
> --- a/mysql-test/r/bootstrap.result	2007-02-20 11:48:15 +0000
> +++ b/mysql-test/r/bootstrap.result	2011-03-23 17:03:42 +0000
> @@ -6,3 +6,15 @@ set @my_max_allowed_packet= @@max_allowe
>  set global max_allowed_packet=100*@@max_allowed_packet;
>  set global max_allowed_packet=@my_max_allowed_packet;
>  drop table t1;
> +End of 5.1 tests
> +#
> +# Bug #11766306: 59393: HAVE_INNODB=YES WHEN MYSQLD 
> +#  STARTED WITH --SKIP-INNODB
> +#
> +SHOW VARIABLES LIKE 'have_innodb';
> +Variable_name	Value
> +have_innodb	DISABLED
> +SELECT SUPPORT FROM INFORMATION_SCHEMA.ENGINES WHERE engine='innodb';
> +SUPPORT
> +NO
> +End of 5.5 tests
If InnoDB is not compiled into the server there should be no row matching
'innodb' in I_S.ENGINES. But as far as I can see this test case cannot
be ran in this situation. So I guess it is not a problem. 

Regards,
Sergey
-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.5 branch (Georgi.Kodinov:3396) Bug#11766306Georgi Kodinov23 Mar
  • Re: bzr commit into mysql-5.5 branch (Georgi.Kodinov:3396)Bug#11766306Sergey Vojtovich24 Mar