From: Bjorn Munch
Date: March 23 2011 9:48am
Subject: bzr commit into mysql-5.1 branch (bjorn.munch:3627)
List-Archive: http://lists.mysql.com/commits/133595
Message-Id: <201103230948.p2N9mFeE012849@khepri15.norway.sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

#At file:///home/bm136801/my/merge-51/ based on revid:magne.mahre@stripped

 3627 Bjorn Munch	2011-03-23 [merge]
      merge from 5.1-mtr

    added:
      mysql-test/include/not_crashrep.inc
    modified:
      client/mysqltest.cc
      mysql-test/suite/binlog/t/binlog_index.test
      mysql-test/suite/innodb/t/innodb_bug53756.test
      mysql-test/suite/innodb_plugin/t/innodb_bug53756.test
      mysql-test/t/crash_commit_before.test
      mysql-test/t/myisam_crash_before_flush_keys.test
=== modified file 'client/mysqltest.cc'
--- a/client/mysqltest.cc	2011-01-26 15:34:34 +0000
+++ b/client/mysqltest.cc	2011-03-18 11:13:54 +0000
@@ -8032,13 +8032,15 @@ int main(int argc, char **argv)
     cur_file->lineno= 1;
   }
   init_re();
+
+  /* Cursor protcol implies ps protocol */
+  if (cursor_protocol)
+    ps_protocol= 1;
+
   ps_protocol_enabled= ps_protocol;
   sp_protocol_enabled= sp_protocol;
   view_protocol_enabled= view_protocol;
   cursor_protocol_enabled= cursor_protocol;
-  /* Cursor protcol implies ps protocol */
-  if (cursor_protocol_enabled)
-    ps_protocol_enabled= 1;
 
   st_connection *con= connections;
   if (!( mysql_init(&con->mysql)))

=== added file 'mysql-test/include/not_crashrep.inc'
--- a/mysql-test/include/not_crashrep.inc	1970-01-01 00:00:00 +0000
+++ b/mysql-test/include/not_crashrep.inc	2011-03-15 15:06:59 +0000
@@ -0,0 +1,24 @@
+# Check if CrashReporter is enabled and would open a window
+
+perl;
+sub skip_test {
+  # Only relevant on Mac OS X
+  return 0 unless $^O eq 'darwin';
+  my $crep= `defaults read com.apple.CrashReporter DialogType`;
+  return 0 if $?;
+  chomp ($crep);
+  $crep= lc $crep;
+  return ($crep eq 'basic' || $crep eq 'developer');
+}
+my $skip= skip_test();
+open (F, ">" . $ENV{'MYSQL_TMP_DIR'} . "/crashrep.inc");
+print F "let \$crashrep= $skip;\n";
+close F;
+EOF
+
+--source $MYSQL_TMP_DIR/crashrep.inc
+--remove_file $MYSQL_TMP_DIR/crashrep.inc
+
+if ($crashrep) {
+  --skip CrashReporter would popup a window
+}

=== modified file 'mysql-test/suite/binlog/t/binlog_index.test'
--- a/mysql-test/suite/binlog/t/binlog_index.test	2010-12-17 01:17:03 +0000
+++ b/mysql-test/suite/binlog/t/binlog_index.test	2011-03-15 15:06:59 +0000
@@ -6,6 +6,8 @@ source include/not_embedded.inc;
 # Don't test this under valgrind, memory leaks will occur
 --source include/not_valgrind.inc
 source include/have_debug.inc;
+# Avoid CrashReporter popup on Mac
+--source include/not_crashrep.inc
 call mtr.add_suppression('Attempting backtrace');
 call mtr.add_suppression('MSYQL_BIN_LOG::purge_logs failed to process registered files that would be purged.');
 call mtr.add_suppression('MSYQL_BIN_LOG::open failed to sync the index file');

=== modified file 'mysql-test/suite/innodb/t/innodb_bug53756.test'
--- a/mysql-test/suite/innodb/t/innodb_bug53756.test	2010-09-30 08:28:22 +0000
+++ b/mysql-test/suite/innodb/t/innodb_bug53756.test	2011-03-15 15:06:59 +0000
@@ -17,6 +17,9 @@
 # This test case needs InnoDB.
 --source include/have_innodb.inc
 
+# Avoid CrashReporter popup on Mac
+--source include/not_crashrep.inc
+
 #
 # Precautionary clean up.
 #

=== modified file 'mysql-test/suite/innodb_plugin/t/innodb_bug53756.test'
--- a/mysql-test/suite/innodb_plugin/t/innodb_bug53756.test	2010-10-03 17:39:28 +0000
+++ b/mysql-test/suite/innodb_plugin/t/innodb_bug53756.test	2011-03-15 15:06:59 +0000
@@ -17,6 +17,9 @@
 # This test case needs InnoDB.
 -- source include/have_innodb_plugin.inc
 
+# Avoid CrashReporter popup on Mac
+--source include/not_crashrep.inc
+
 #
 # Precautionary clean up.
 #

=== modified file 'mysql-test/t/crash_commit_before.test'
--- a/mysql-test/t/crash_commit_before.test	2007-12-12 17:19:24 +0000
+++ b/mysql-test/t/crash_commit_before.test	2011-03-15 15:06:59 +0000
@@ -1,6 +1,8 @@
 -- source include/not_embedded.inc
 # Don't test this under valgrind, memory leaks will occur
 --source include/not_valgrind.inc
+# Avoid CrashReporter popup on Mac
+--source include/not_crashrep.inc
 
 # Binary must be compiled with debug for crash to occur
 --source include/have_debug.inc

=== modified file 'mysql-test/t/myisam_crash_before_flush_keys.test'
--- a/mysql-test/t/myisam_crash_before_flush_keys.test	2009-10-14 11:26:16 +0000
+++ b/mysql-test/t/myisam_crash_before_flush_keys.test	2011-03-15 15:06:59 +0000
@@ -8,6 +8,9 @@
 --echo # Binary must be compiled with debug for crash to occur
 --source include/have_debug.inc
 
+# Avoid CrashReporter popup on Mac
+--source include/not_crashrep.inc
+
 let $MYSQLD_DATADIR= `select @@datadir`;
 SET GLOBAL delay_key_write=ALL;
 CREATE TABLE t1(a INT, 

No bundle (reason: revision is a merge).