List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:March 21 2011 3:36pm
Subject:Re: bzr commit into mysql-5.0 branch (magne.mahre:2907) Bug#11840513
View as plain text  
Hello,

Comments below.

I can still find references to some of these files:

>      removed:
>        include/my_handler.h
>        mysys/my_handler.c

myisam/mi_range.c:    my_handler.c:mi_compare_text() has a flag 
'skip_end_space'.
myisam/mi_range.c:    This is set in my_handler.c:ha_key_cmp() in 
dependence on the
VC++Files/mysys/mysys.dsp:SOURCE=.\my_handler.c
VC++Files/mysys/mysys.vcproj:                   RelativePath="my_handler.c">
VC++Files/mysys/mysys_ia64.dsp:SOURCE=.\my_handler.c

>        mysys/my_gethostbyname.c

VC++Files/mysys/mysys.dsp:SOURCE=.\my_gethostbyname.c
VC++Files/mysys/mysys.vcproj: 
RelativePath="my_gethostbyname.c">
VC++Files/mysys/mysys_ia64.dsp:SOURCE=.\my_gethostbyname.c
VC++Files/libmysql/libmysql_ia64.dsp:SOURCE=..\mysys\my_gethostbyname.c
VC++Files/libmysql/libmysql.dsp:SOURCE=..\mysys\my_gethostbyname.c
VC++Files/libmysql/libmysql.vcproj: 
RelativePath="..\mysys\my_gethostbyname.c">
VC++Files/client/mysqlclient.vcproj: 
RelativePath="..\mysys\my_gethostbyname.c">
VC++Files/client/mysqlclient.dsp:SOURCE=..\mysys\my_gethostbyname.c
VC++Files/client/mysqlclient_ia64.dsp:SOURCE=..\mysys\my_gethostbyname.c

> === added file 'include/my_compare.h'
> --- a/include/my_compare.h	1970-01-01 00:00:00 +0000
> +++ b/include/my_compare.h	2011-03-21 12:21:22 +0000
> @@ -0,0 +1,89 @@
> +/* Copyright (c) 2000-2011, Oracle and/or its affiliates. All rights reserved.

Maybe remove 2000 since this is a new file?

> === modified file 'include/my_global.h'
> --- a/include/my_global.h	2009-12-17 11:25:50 +0000
> +++ b/include/my_global.h	2011-03-21 12:21:22 +0000
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 2000-2003 MySQL AB
> +/* Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.

2010 => 2011

> === modified file 'myisam/ft_stopwords.c'
> --- a/myisam/ft_stopwords.c	2006-12-31 00:02:27 +0000
> +++ b/myisam/ft_stopwords.c	2011-03-21 12:21:22 +0000

Update copyright header here?


Otherwise looks ok,

--- Jon Olav
Thread
bzr commit into mysql-5.0 branch (magne.mahre:2907) Bug#11840513Magne Mahre21 Mar
  • Re: bzr commit into mysql-5.0 branch (magne.mahre:2907) Bug#11840513Jon Olav Hauglid21 Mar