From: Dmitry Lenev
Date: March 21 2011 11:52am
Subject: Re: bzr commit into mysql-5.5 branch (magnus.blaudd:3353) Bug#60111
List-Archive: http://lists.mysql.com/commits/133407
Message-Id: <20110321115202.GA19194@bandersnatch>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hello, Magnus!

* Magnus Bl=E5udd <magnus.blaudd@stripped> [11/03/18 10:05]:
> thanks for your review. I have one final questions, see below. Once
> I go that answered, I'll proceed and push this.

...

> >>=3D=3D=3D modified file 'sql/sql_show.cc'
> >>--- a/sql/sql_show.cc	2011-02-08 15:47:33 +0000
> >>+++ b/sql/sql_show.cc	2011-03-04 08:41:29 +0000
> >>@@ -1379,17 +1379,24 @@ int store_create_info(THD *thd, TABLE_LI
> >>    if (!(thd->variables.sql_mode&  MODE_NO_TABLE_OPTIONS)&&  !foreig=
n_db_mode)
> >>    {
> >>      show_table_options=3D TRUE;
> >>-    /*
> >>-      Get possible table space definitions and append them
> >>-      to the CREATE TABLE statement
> >>-    */
> >>
> >>-    if ((for_str=3D file->get_tablespace_name(thd,0,0)))
> >>+    /* TABLESPACE and STORAGE */
> >>+    if (share->tablespace ||
> >>+        share->default_storage_media !=3D HA_SM_DEFAULT)
> >>      {
> >>-      packet->append(STRING_WITH_LEN(" /*!50100 TABLESPACE "));
> >>-      packet->append(for_str, strlen(for_str));
> >>-      packet->append(STRING_WITH_LEN(" STORAGE DISK */"));
> >>-      my_free(for_str);
> >>+      packet->append(STRING_WITH_LEN(" /*!50100"));
> >>+      if (share->tablespace)
> >>+      {
> >>+        packet->append(STRING_WITH_LEN(" TABLESPACE "));
> >>+        packet->append(share->tablespace, strlen(share->tablespace))=
;
> >>+      }
> >>+
> >>+      if (share->default_storage_media =3D=3D HA_SM_DISK)
> >>+        packet->append(STRING_WITH_LEN(" STORAGE DISK"));
> >>+      if (share->default_storage_media =3D=3D HA_SM_MEMORY)
> >>+        packet->append(STRING_WITH_LEN(" STORAGE MEMORY"));
> >>+
> >>+      packet->append(STRING_WITH_LEN(" */"));
> >>      }
> >>
> >>      /*
> >
> >Maybe it makes sense to also adjust store_schema_partitions_record()
> >code so it will no longer use handler::get_tablespace_name()?
>=20
>=20
> Yes, I can do that. But since there are then no use of
> handler::get_tablespace_name(), should I remove that function? My
> suggestion is to remove it.

I think it is OK to remove this function starting from mysql-trunk.


Best regards,
Dmitry

--=20
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com

Are you MySQL certified?  http://www.mysql.com/certification