Hi Andrei,
Please, address some minor comments.
1.
> > === modified file 'sql/sql_trigger.cc'
> > --- a/sql/sql_trigger.cc 2010-11-29 16:27:58 +0000
> > +++ b/sql/sql_trigger.cc 2011-02-21 15:43:57 +0000
> > @@ -521,6 +521,8 @@ bool mysql_create_or_drop_trigger(THD *t
> > end:
> > if (!result)
> > {
> > + if (tables)
> > + thd->add_one_db_to_binlog_updated_dbs(tables->db);
Can you explain the "if"?
The call to write to the binary takes place without checking if tables is null.
2. I think statements that are not specially handled such as ALTER DATABASE, ALTER
PROCEDURE, should be listed
in the WL and some comments should be written on them.
3. Please, use /* */ for comments that need more than one line.
+ // Releasing the Coord's mem-root from the updated dbs. It's safe to do at this
+ // point because the root is no longer needed along remained part of Coordinator's
+ // execution flow.
Cheers.
