From: Jon Olav Hauglid Date: March 17 2011 11:23am Subject: bzr commit into mysql-trunk branch (jon.hauglid:3779) Bug#11829666 List-Archive: http://lists.mysql.com/commits/133194 X-Bug: 11829666 Message-Id: <201103171123.p2HBNqEq006059@acsmt358.oracle.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4115834152740379097==" --===============4115834152740379097== MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline #At file:///export/home/x/mysql-trunk-bug60180/ based on revid:nirbhay.choubey@stripped 3779 Jon Olav Hauglid 2011-03-17 Bug #11829666 (former 60180) Unused mutex THR_LOCK_isam The problem was that the THR_LOCK_isam mutex was declared, initialized and destroyed, but not used anywhere. This patch removes the THR_LOCK_isam mutex completely. No functional changes. No test case added. modified: mysql-test/suite/perfschema/r/server_init.result mysql-test/suite/perfschema/t/server_init.test mysys/my_init.c mysys/my_thr_init.c mysys/mysys_priv.h === modified file 'mysql-test/suite/perfschema/r/server_init.result' --- a/mysql-test/suite/perfschema/r/server_init.result 2011-01-13 11:31:20 +0000 +++ b/mysql-test/suite/perfschema/r/server_init.result 2011-03-17 11:23:31 +0000 @@ -12,10 +12,6 @@ where name like "wait/synch/mutex/mysys/ count(name) 1 select count(name) from mutex_instances -where name like "wait/synch/mutex/mysys/THR_LOCK_isam"; -count(name) -1 -select count(name) from mutex_instances where name like "wait/synch/mutex/mysys/THR_LOCK_myisam"; count(name) 1 === modified file 'mysql-test/suite/perfschema/t/server_init.test' --- a/mysql-test/suite/perfschema/t/server_init.test 2011-01-13 11:31:20 +0000 +++ b/mysql-test/suite/perfschema/t/server_init.test 2011-03-17 11:23:31 +0000 @@ -38,9 +38,6 @@ select count(name) from mutex_instances where name like "wait/synch/mutex/mysys/THR_LOCK_open"; select count(name) from mutex_instances - where name like "wait/synch/mutex/mysys/THR_LOCK_isam"; - -select count(name) from mutex_instances where name like "wait/synch/mutex/mysys/THR_LOCK_myisam"; select count(name) from mutex_instances === modified file 'mysys/my_init.c' --- a/mysys/my_init.c 2011-03-01 13:39:58 +0000 +++ b/mysys/my_init.c 2011-03-17 11:23:31 +0000 @@ -474,7 +474,7 @@ PSI_mutex_key key_LOCK_gethostbyname_r; PSI_mutex_key key_BITMAP_mutex, key_IO_CACHE_append_buffer_lock, key_IO_CACHE_SHARE_mutex, key_KEY_CACHE_cache_lock, key_LOCK_alarm, key_my_thread_var_mutex, key_THR_LOCK_charset, key_THR_LOCK_heap, - key_THR_LOCK_isam, key_THR_LOCK_lock, key_THR_LOCK_malloc, + key_THR_LOCK_lock, key_THR_LOCK_malloc, key_THR_LOCK_mutex, key_THR_LOCK_myisam, key_THR_LOCK_net, key_THR_LOCK_open, key_THR_LOCK_threads, key_TMPDIR_mutex, key_THR_LOCK_myisam_mmap; @@ -498,7 +498,6 @@ static PSI_mutex_info all_mysys_mutexes[ { &key_my_thread_var_mutex, "my_thread_var::mutex", 0}, { &key_THR_LOCK_charset, "THR_LOCK_charset", PSI_FLAG_GLOBAL}, { &key_THR_LOCK_heap, "THR_LOCK_heap", PSI_FLAG_GLOBAL}, - { &key_THR_LOCK_isam, "THR_LOCK_isam", PSI_FLAG_GLOBAL}, { &key_THR_LOCK_lock, "THR_LOCK_lock", PSI_FLAG_GLOBAL}, { &key_THR_LOCK_malloc, "THR_LOCK_malloc", PSI_FLAG_GLOBAL}, { &key_THR_LOCK_mutex, "THR_LOCK::mutex", 0}, === modified file 'mysys/my_thr_init.c' --- a/mysys/my_thr_init.c 2011-03-01 13:39:58 +0000 +++ b/mysys/my_thr_init.c 2011-03-17 11:23:31 +0000 @@ -24,7 +24,7 @@ pthread_key(struct st_my_thread_var*, THR_KEY_mysys); mysql_mutex_t THR_LOCK_malloc, THR_LOCK_open, - THR_LOCK_lock, THR_LOCK_isam, THR_LOCK_myisam, THR_LOCK_heap, + THR_LOCK_lock, THR_LOCK_myisam, THR_LOCK_heap, THR_LOCK_net, THR_LOCK_charset, THR_LOCK_threads, THR_LOCK_myisam_mmap; @@ -88,9 +88,6 @@ void my_thread_global_reinit(void) my_init_mysys_psi_keys(); #endif - mysql_mutex_destroy(&THR_LOCK_isam); - mysql_mutex_init(key_THR_LOCK_isam, &THR_LOCK_isam, MY_MUTEX_INIT_SLOW); - mysql_mutex_destroy(&THR_LOCK_heap); mysql_mutex_init(key_THR_LOCK_heap, &THR_LOCK_heap, MY_MUTEX_INIT_FAST); @@ -212,7 +209,6 @@ my_bool my_thread_global_init(void) #endif /* TARGET_OS_LINUX */ mysql_mutex_init(key_THR_LOCK_lock, &THR_LOCK_lock, MY_MUTEX_INIT_FAST); - mysql_mutex_init(key_THR_LOCK_isam, &THR_LOCK_isam, MY_MUTEX_INIT_SLOW); mysql_mutex_init(key_THR_LOCK_myisam, &THR_LOCK_myisam, MY_MUTEX_INIT_SLOW); mysql_mutex_init(key_THR_LOCK_myisam_mmap, &THR_LOCK_myisam_mmap, MY_MUTEX_INIT_FAST); mysql_mutex_init(key_THR_LOCK_heap, &THR_LOCK_heap, MY_MUTEX_INIT_FAST); @@ -275,7 +271,6 @@ void my_thread_global_end(void) mysql_mutex_destroy(&THR_LOCK_malloc); mysql_mutex_destroy(&THR_LOCK_open); mysql_mutex_destroy(&THR_LOCK_lock); - mysql_mutex_destroy(&THR_LOCK_isam); mysql_mutex_destroy(&THR_LOCK_myisam); mysql_mutex_destroy(&THR_LOCK_myisam_mmap); mysql_mutex_destroy(&THR_LOCK_heap); === modified file 'mysys/mysys_priv.h' --- a/mysys/mysys_priv.h 2011-01-13 11:31:20 +0000 +++ b/mysys/mysys_priv.h 2011-03-17 11:23:31 +0000 @@ -1,4 +1,4 @@ -/* Copyright (C) 2000 MySQL AB, 2008-2009 Sun Microsystems, Inc +/* Copyright (c) 2000, 2011 Oracle and/or its affiliates. All rights reserved. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -43,7 +43,7 @@ extern PSI_mutex_key key_LOCK_gethostbyn extern PSI_mutex_key key_BITMAP_mutex, key_IO_CACHE_append_buffer_lock, key_IO_CACHE_SHARE_mutex, key_KEY_CACHE_cache_lock, key_LOCK_alarm, key_my_thread_var_mutex, key_THR_LOCK_charset, key_THR_LOCK_heap, - key_THR_LOCK_isam, key_THR_LOCK_lock, key_THR_LOCK_malloc, + key_THR_LOCK_lock, key_THR_LOCK_malloc, key_THR_LOCK_mutex, key_THR_LOCK_myisam, key_THR_LOCK_net, key_THR_LOCK_open, key_THR_LOCK_threads, key_TMPDIR_mutex, key_THR_LOCK_myisam_mmap; @@ -59,7 +59,7 @@ extern PSI_thread_key key_thread_alarm; #endif /* HAVE_PSI_INTERFACE */ extern mysql_mutex_t THR_LOCK_malloc, THR_LOCK_open, THR_LOCK_keycache; -extern mysql_mutex_t THR_LOCK_lock, THR_LOCK_isam, THR_LOCK_net; +extern mysql_mutex_t THR_LOCK_lock, THR_LOCK_net; extern mysql_mutex_t THR_LOCK_charset; #include --===============4115834152740379097== MIME-Version: 1.0 Content-Type: text/bzr-bundle; charset="us-ascii"; name="bzr/jon.hauglid@stripped" Content-Transfer-Encoding: 7bit Content-Disposition: inline # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: jon.hauglid@stripped # target_branch: file:///export/home/x/mysql-trunk-bug60180/ # testament_sha1: d23f18bb790a370c307e8c3d5f091f46275ca7d2 # timestamp: 2011-03-17 12:23:35 +0100 # base_revision_id: nirbhay.choubey@stripped\ # alfex7t2zly8a85c # # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWVGr/+MABAJfgAAQWHf//3pd lgC////wYAfPvO9znaSbZSsfd9ei2rV7HvW6elwkkKaj1PJkm1PQzU1D1Gj1AaABoACSQmQaaGhK fpNT01PVDymmjRoGQekANKnhTeqGmTQDTNTI0AAABoYgkRCIjTGVPKH5U0NHqDQAG1A2oAilTKPy SaAA00zRqDT1DQAAB6gkkCaA0iY0aamJpPQUaZqNqaA0A3luque2dmZtDl6V59nhN8FmK2xIal76 45KqmdBwqJHRi4LmBmAqjFF1TRsum66EI7JQfZenr3pG/JH4hiDGxsbBtL79iRdQsM2XwbXjs2zh hBF8F8xR6MXBVtlXL3xWaZQm4dz+m/w8sdOv+cTuSRy0w5p6RjZFHp/veG3YwH+wp4opJyJz7ueL KbhDyRlftuzL1ZddKjXEEJNRGoguCCyjUCC6QIhcAYZ6PqBUVYwB7GZEwGOIledzKYkSCCq5nGX2 C1MWxLlQsecdouCrjo55PDxV4qlUjBMkuacknEBdskQlFHNZGdhGtxnCNTIaUDDOejCsqvlUz0is LGS+0CsKoobEiBQqjkViwy8gVASqWyLYjzEgULouHkhTSwvUDEmegXE44wFsTHCVBGE7nirrMBKK d0gCueviw8TAjea8LYgKaYTCTLBMe6MoBaLFhKNZ32uM9J0uA+GBVJwveX4ir30eYll2TbDPGvuw 0KoCUfbgZfRmLh5YibtSpk4V5MS3VoY+1ZlYqWkxOYSHi6s+ps8TZOEhJuBAdlftHpZFCl5ebbgP MVC0mfeskxsdVI1JXWatN+8xOYqMJhJyZk5AahcJcoGo1iLjsc344lUWlDE6TKEI2tqdy4pkzTdp wUS3tHkHOvxTLYPdBCTRqMDhSU2sBQZlDYPGImwfWdBKJmMchQtbXlM2UZtVLCNaqJ3sXDhiA+VG KLdiJb1ep624GAwrx65lLCCgPKmPM6nIy02q+jQmzcr8st5yFuQtlbJZ7jrMbVbPxZqUzk26kyBF 46eWKW6RExC85ncq3tqdVc5znQoLYbnFs0BGZfpGERMaezkPeTtoa6pSGOD1H9r7D/EyfW9t24G5 Dh0M3Zkn4kiaeZQvIwuiSPCUTLDO07LeXki0tFWQLB0ygtrEMR+WT6yehYPFqt1Choc8y0oaYFw5 lOaNZubiCfCTPDdwoapnpNJ1FeBde+nzi3RzrQ22uCNkpttgb+tHXcqlUlktE6QbYNj+uX5BVr2g opxBfsFefoFU/AJhLoDIXIFzh247NQ006e1jAqqAMXUzQHfITPNrMRjH9FkvLCV4CRlLCpqLD+bq Q+Ezy7c/nvQiooacPUdwkB5Bp7L4r6ECQRRyqmZs4mltpQu1ZzTj3GxUO1QSVCl6FOQWu41kKzIQ GWtidCrwHGh7nXBeycZKHK9aZ1C9UI4mH81jw6GB5HIl3CrzY2GKkDTkfVeYGB6uNsB5jkYHgK44 NzeGnO7crsghe9CIJI4y8BKe4Ccx7I2ph2849YR2cCRgahxZGBYlYk8dIqJCFguORQmFmOcWe/qK vZrOq4DugncnAjWMjcYmS3H0oROyLSWRItOvbzRmjI7zYOzOzRmBU7mPUidemOurPp7f1eXBffjH ysR3qMzOErPd4/NSlQmS0U5ZMQs1T+ByUN8OdnFWwBrYKs6mvCAFS0TAsmLF9Qt4C3QGPEuNBwKQ mFjWUV/yilGpElwsolVAvwZ1iiJYdSzPMe5UQWQXqaiQB6EjuXDs3r4ph5gCbo9JeKcB+e3411VS zYzWCuWZDgbwSPJaET626btzdzqkOSTo+QpHeAPNOwF9YJuXPg/QCeCxmvu1gPIIU/PJXJVPcJZq xdRfE/ATI0r0Ri24qBUDoWo1GJns45CC4CYCdpz9nsUehDBDEcJ0inmAOP773HpqMDWGogn4LH5K ejD3O8kkZnoWkVBRQ6OJy5qXQsnUKG84q3WcTp8BmITk9QYwro2xMAbxkqkQV8WJASJWPhOxPQqq 9RE5AYshkjQXmULS3UN/TuOkeExG1eGLDXZmZUwsF2C+kmAulNk2DfwIoAyBqcsI3rjVs9Tq0DyO lkQsUjO0xtGrhyMp0M/V1DIQ0VxrRmodlgbaQW2hotpKoroyE3msfR4vASq7t0Nq8jEJWqGc3O+p GUwlC3E3bYivMmcCFS1gr3i73GRhXv9TG6iVDNg1IsAeORyV6XyiTVbMzNQtWYwrQG0TLwT4iiaa sO7W/b1hUJi94+gJkfNYInWoI3CK4Of+QlHaFnr7K4HCJ/oO94mNFLTPy3O+gxuagPBtKoVRSeyi pqQuP6cbgDzqE1k0+apZOa7B6jr17ltSYVsVmB4GSzIGKwGEtZAuHLniLE7LvXstSBkvWMHwXmOB VGNugm22TnKCVwt2gU5ieBvz3FztUGU/xdyRThQkFGr/+MA= --===============4115834152740379097==--