bk commit into 4.1 tree (msvensson:1.2566)

[msvensson]

Below is the list of changes that have just been committed into a local
4.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-07 19:11:37+02:00, msvensson@neptunus.(none) +1 -0
  Improve sort algorithm for reorder, all test with smae name except for ending digit should be run after each other. 
  Example of that is ndb_autodiscover[1-3]

  mysql-test/lib/mtr_cases.pl@stripped, 2006-10-07 19:11:35+02:00, msvensson@neptunus.(none) +53 -19
    Improve sort algorithm for reorder, all test with smae name except for ending digit should be run after each other. 
    Example of that is ndb_autodiscover[1-3]

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/mysql-4.1-maint

--- 1.15/mysql-test/lib/mtr_cases.pl	2006-10-07 19:11:40 +02:00
+++ 1.16/mysql-test/lib/mtr_cases.pl	2006-10-07 19:11:40 +02:00
@@ -143,7 +143,7 @@
       {
         next;
       }
-      
+
       next if $::opt_do_test and ! defined mtr_match_prefix($elem,$::opt_do_test);
 
       collect_one_test_case($testdir,$resdir,$tname,$elem,$cases,\%disabled,
@@ -159,37 +159,71 @@
   {
 
     my %sort_criteria;
-    my $tinfo;
 
     # Make a mapping of test name to a string that represents how that test
     # should be sorted among the other tests.  Put the most important criterion
     # first, then a sub-criterion, then sub-sub-criterion, et c.
-    foreach $tinfo (@$cases)
+    foreach my $tinfo (@$cases)
     {
-      my @this_criteria = ();
-
-      #
-      # Append the criteria for sorting, in order of importance.
-      #
-
-      push(@this_criteria, "ndb=" . ($tinfo->{'ndb_test'} ? "1" : "0"));
-      push(@this_criteria, "restart=" . ($tinfo->{'master_restart'} ? "1" : "0"));
-      # Group test with similar options together.
-      # Ending with "~" makes empty sort later than filled
-      push(@this_criteria, join("!", sort @{$tinfo->{'master_opt'}}) . "~");
+      my @criteria = ();
 
-      # Finally, order by the name
-      push(@this_criteria, $tinfo->{'name'});
+      # Look for tests that muct be in run in a defined order
+      # that is defined by test having the same name except for
+      # the ending digit
+
+      # Put variables into hash
+      my $test_name= $tinfo->{'name'};
+      my $depend_on_test_name;
+      if ( $test_name =~ /^([\D]+)([0-9]{1})$/ )
+      {
+	my $base_name= $1;
+	my $idx= $2;
+	mtr_verbose("$test_name =>  $base_name idx=$idx");
+	if ( $idx > 1 )
+	{
+	  $idx-= 1;
+	  $base_name= "$base_name$idx";
+	  mtr_verbose("New basename $base_name");
+	}
+
+	foreach my $tinfo2 (@$cases)
+	{
+	  if ( $tinfo2->{'name'} eq $base_name )
+	  {
+	    mtr_verbose("found dependent test $tinfo2->{'name'}");
+	    $depend_on_test_name=$base_name;
+	  }
+	}
+      }
+
+      if ( defined $depend_on_test_name )
+      {
+	mtr_verbose("Giving $test_name same critera as $depend_on_test_name");
+	$sort_criteria{$test_name} = $sort_criteria{$depend_on_test_name};
+      }
+      else
+      {
+	#
+	# Append the criteria for sorting, in order of importance.
+	#
+	push(@criteria, "ndb=" . ($tinfo->{'ndb_test'} ? "1" : "0"));
+	push(@criteria, "restart=" . ($tinfo->{'master_restart'} ? "1" : "0"));
+	# Group test with equal options together.
+	# Ending with "~" makes empty sort later than filled
+	push(@criteria, join("!", sort @{$tinfo->{'master_opt'}}) . "~");
 
-      $sort_criteria{$tinfo->{"name"}} = join(" ", @this_criteria);
+	$sort_criteria{$test_name} = join(" ", @criteria);
+      }
     }
 
-    @$cases = sort { $sort_criteria{$a->{"name"}} cmp $sort_criteria{$b->{"name"}}; } @$cases;
+    @$cases = sort {
+      $sort_criteria{$a->{'name'}} . $a->{'name'} cmp
+	$sort_criteria{$b->{'name'}} . $b->{'name'}; } @$cases;
 
     if ( $::opt_script_debug )
     {
       # For debugging the sort-order
-      foreach $tinfo (@$cases)
+      foreach my $tinfo (@$cases)
       {
 	print("$sort_criteria{$tinfo->{'name'}} -> \t$tinfo->{'name'}\n");
       }