List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:March 3 2011 2:36pm
Subject:Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217)
View as plain text  
Hi Magnus,

The patch looks fine. However, I need some context to understand what
are your goals. Please, file a bug report and I will take another look
at it and approve it.

See minor comments in-line.

Cheers.

On 02/21/2011 01:18 PM, Magnus Blåudd wrote:
> #At file:///data0/magnus/mysql/5.5-telco-7.0/ based on
> revid:magnus.blaudd@stripped
> 
>  3217 Magnus Blåudd	2011-02-21
>       ndb
>        - add MCP patch for WL3733 slave_allow_batching
>        - update sys_vars.slave_allow_batching testcase
>
> @@ -7821,7 +7827,11 @@ int Rows_log_event::do_apply_event(Relay
>      }
>    } // if (table)
>  
> -  
> +#ifndef MCP_WL3733
> +  /* reset OPTION_ALLOW_BATCH as not affect later events */
> +  thd->variables.option_bits&= ~OPTION_ALLOW_BATCH;
> +#endif
> +

I think this is not necessary.



>    if (error)
>    {
>      slave_rows_error_report(ERROR_LEVEL, error, rli, thd, table,
> @@ -9152,6 +9162,24 @@ int Rows_log_event::find_row(const Relay
>                                   table->s->reclength) == 0);
>  
>      */
> +
> +#ifndef MCP_WL3733
> +    /*
> +      Ndb does not need read before delete/update (and no updates are sent)
> +      if primary key specified
> +
> +      (Actually uniquekey will also do, but pk will be in each
> +      row if table has pk)
> +
> +      Also set ignore no key, as we don't really know if row exists...
> +    */
> +    if (table->file->ht->db_type == DB_TYPE_NDBCLUSTER)
> +    {
> +      table->file->extra(HA_EXTRA_IGNORE_NO_KEY);
> +      DBUG_RETURN(0);
> +    }
> +#endif 

Sorry but I did not get what you are trying to achieve with this part of the patch.
Maybe, due to lack of some context. Can you file a bug report and improve your
comments?
Thread
bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217) Magnus Blåudd21 Feb
Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217)Alfranio Correia3 Mar
  • Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217)Magnus Blåudd3 Mar
    • Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217)Alfranio Correia3 Mar
      • Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3217)Magnus Blåudd4 Mar