List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:March 3 2011 9:56am
Subject:Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341
Bug#11764503
View as plain text  
Hello,

Alexander Barkov a écrit, Le 01.03.2011 11:24:
> #At file:///home/bar/mysql-bzr/mysql-5.5.b57341/ based on
> revid:tor.didriksen@stripped
> 
>  3357 Alexander Barkov	2011-03-01
>       Bug#11764503 (Bug#57341) Query in EXPLAIN EXTENDED shows wrong characters
>       
>         @ mysql-test/r/ctype_latin1.result
>         @ mysql-test/r/ctype_utf8.result
>         @ mysql-test/t/ctype_latin1.test
>         @ mysql-test/t/ctype_utf8.test
>         Adding tests

Ok to push.
I had looked at Item_string::print() earlier and found that its 
execution flow is hard to read.
So here is a proposal (incremental over your patch) which makes 
Item_string::print() hopefully clearer.
I also added comments which explain the reasons behind what is done for 
QT_EXPLAIN (something I understood after a gdb session :-).

http://lists.mysql.com/commits/132357

I hope you'll like it. If you don't want it, your patch is still ok to 
push, but could you please at least incorporate my comment about 
QT_EXPLAIN ("Because we wrote an introducer" etc)?

Thanks.
Thread
bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Alexander Barkov1 Mar
  • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Guilhem Bichot1 Mar
    • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Alexander Barkov1 Mar
      • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Guilhem Bichot2 Mar
        • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Alexander Barkov3 Mar
  • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Guilhem Bichot3 Mar
    • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Alexander Barkov4 Mar
      • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Guilhem Bichot4 Mar
        • Re: bzr commit into mysql-5.5 branch (alexander.barkov:3357) Bug#57341Bug#11764503Alexander Barkov4 Mar