List:Commits« Previous MessageNext Message »
From:Alexander Barkov Date:March 3 2011 8:28am
Subject:bzr commit into mysql-5.1 branch (alexander.barkov:3607) Bug#58036
Bug#11765108
View as plain text  
#At file:///home/bar/mysql-bzr/mysql-5.1/ based on revid:vinay.fisrekar@stripped

 3607 Alexander Barkov	2011-03-03
      An after-fix for
      Bug#11765108 - Bug#58036: CLIENT UTF32, UTF16, UCS2 SHOULD BE DISALLOWED, THEY CRASH SERVER 
      
      Fixing wrong usage of DBUG_ASSERT.
      In non-debug version thd_init_client_charset
      was not executed at all.

    modified:
      sql/sql_parse.cc
=== modified file 'sql/sql_parse.cc'
--- a/sql/sql_parse.cc	2011-02-22 21:03:32 +0000
+++ b/sql/sql_parse.cc	2011-03-03 08:25:37 +0000
@@ -1218,7 +1218,8 @@ bool dispatch_command(enum enum_server_c
           We have checked charset earlier,
           so thd_init_client_charset cannot fail.
         */
-        DBUG_ASSERT(!thd_init_client_charset(thd, cs_number));
+        if (thd_init_client_charset(thd, cs_number))
+          DBUG_ASSERT(0);
         thd->update_charset();
       }
     }


Attachment: [text/bzr-bundle] bzr/alexander.barkov@oracle.com-20110303082537-27l0ldhayo0bl0et.bundle
Thread
bzr commit into mysql-5.1 branch (alexander.barkov:3607) Bug#58036Bug#11765108Alexander Barkov3 Mar