List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:October 6 2006 10:29am
Subject:bk commit into 5.0 tree (svoj:1.2293)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-06 15:29:30+05:00, svoj@stripped +1 -0
  Merge mysql.com:/home/svoj/devel/mysql/BUG22937/mysql-4.1-engines
  into  mysql.com:/home/svoj/devel/mysql/BUG22937/mysql-5.0-engines
  MERGE: 1.1616.2144.207

  sql/ha_myisammrg.cc@stripped, 2006-10-06 15:29:28+05:00, svoj@stripped +2 -3
    Manual merge.
    MERGE: 1.51.1.12

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	svoj
# Host:	april.(none)
# Root:	/home/svoj/devel/mysql/BUG22937/mysql-5.0-engines/RESYNC

--- 1.80/sql/ha_myisammrg.cc	2006-10-06 15:29:34 +05:00
+++ 1.81/sql/ha_myisammrg.cc	2006-10-06 15:29:34 +05:00
@@ -326,9 +326,22 @@ void ha_myisammrg::info(uint flag)
   if (flag & HA_STATUS_CONST)
   {
     if (table->s->key_parts && info.rec_per_key)
+    {
+#ifdef HAVE_purify
+      /*
+        valgrind may be unhappy about it, because optimizer may access values
+        between file->keys and table->key_parts, that will be uninitialized.
+        It's safe though, because even if opimizer will decide to use a key
+        with such a number, it'll be an error later anyway.
+      */
+      bzero((char*) table->key_info[0].rec_per_key,
+            sizeof(table->key_info[0].rec_per_key) * table->key_parts);
+#endif
       memcpy((char*) table->key_info[0].rec_per_key,
 	     (char*) info.rec_per_key,
-	     sizeof(table->key_info[0].rec_per_key)*table->s->key_parts);
+             sizeof(table->key_info[0].rec_per_key) *
+             min(file->keys, table->s->key_parts));
+    }
   }
 }
 
Thread
bk commit into 5.0 tree (svoj:1.2293)Sergey Vojtovich6 Oct