List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:February 24 2011 3:06pm
Subject:RE: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3170)
View as plain text  

> -----Original Message-----
> From: Bjorn Munch [mailto:bjorn.munch@stripped]
> Sent: Donnerstag, 24. Februar 2011 15:11
> To: commits@stripped
> Subject: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3170)
> 
> #At file:///home/bm136801/my/mtr-55/ based on
> revid:bjorn.munch@stripped
> 

Hi Bjorn! Thanks for the patch.

> +  # Add vs-config option on Windows if needed
> +  $ctest_vs= "-C $opt_vs_config" if IS_WINDOWS && $opt_vs_config;

It is not  Windows only. .  Xcode on OSX behaves very similarly (or for our
purposes, exactly) like VS on Windows here, and so does opt_vs_config .
Multi-configuration is a property of CMAKE_GENERATOR. Xcode and Visual
Studio  have it,  while  Makefiles do not.  I tried to describe  here how to
mtr-test with Xcode
http://forge.mysql.com/wiki/CMake#Running_mysql-test-run.pl_with_Visual_Stud
io_or_Xcode_projects .  

Thus believe it is better not to check for Windows here, those who set
MTR_VS_CONFIG shall know what they do.

Wlad


Thread
bzr commit into mysql-5.5-mtr branch (bjorn.munch:3170) Bjorn Munch24 Feb
  • RE: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3170) Vladislav Vaintroub24 Feb