List:Commits« Previous MessageNext Message »
From:Maitrayi Sabaratnam Date:February 24 2011 1:03pm
Subject:bzr commit into mysql-5.1-telco-6.3 branch (msabaratnam:3393) Bug#11760678
View as plain text  
#At file:///export/home2/tmp/maitrayi/mysql-repo/repo-6.3/mysql-5.1-telco-6.3-bug11760678/ based on revid:jonas@stripped

 3393 Maitrayi Sabaratnam	2011-02-24
      Bug#11760678 - 53106: WEIRD BEHAVIOR WITH UNDO_BUFFER_SIZE TO LARGE FOR SHAREDGLOBALMEMORY

    modified:
      storage/ndb/src/kernel/blocks/lgman.cpp
=== modified file 'storage/ndb/src/kernel/blocks/lgman.cpp'
--- a/storage/ndb/src/kernel/blocks/lgman.cpp	2011-01-30 20:42:21 +0000
+++ b/storage/ndb/src/kernel/blocks/lgman.cpp	2011-02-24 13:02:28 +0000
@@ -981,19 +981,15 @@ Lgman::alloc_logbuffer_memory(Ptr<Logfil
     }
   }
 
-  if(2*pages > requested)
+  if(pages)
   {
-    // less than half allocated
+    /* Could not allocate all of the requested memory.
+     * So release that already allocated.
+     */
     free_logbuffer_memory(ptr);
     return false;
   }
   
-  if(pages != 0)
-  {
-    warningEvent("Allocated %d pages for log buffer space, logfile_group: %d"
-		 " , requested %d pages", 
-		 (requested-pages), ptr.p->m_logfile_group_id, requested);
-  }
 #if defined VM_TRACE || defined ERROR_INSERT
   ndbout << "DD lgman: fg id:" << ptr.p->m_logfile_group_id << " undo buffer pages/bytes:" << (requested-pages) << "/" << (requested-pages)*File_formats::NDB_PAGE_SIZE << endl;
 #endif


Attachment: [text/bzr-bundle] bzr/msabaratnam@mysql.com-20110224130228-q71iq4o0jfnxy1vn.bundle
Thread
bzr commit into mysql-5.1-telco-6.3 branch (msabaratnam:3393) Bug#11760678Maitrayi Sabaratnam24 Feb