List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:February 23 2011 2:41pm
Subject:Re: bzr commit into mysql-5.5 branch (tor.didriksen:3354) Bug#11747102
View as plain text  
Hi Tor,

On 2/23/11 11:26 AM, Tor Didriksen wrote:
> #At file:///export/home/didrik/repo/5.5-filesort-kill/ based on
> revid:nirbhay.choubey@stripped
>
>   3354 Tor Didriksen	2011-02-23
>        Bug #11747102 30771: LOG MORE INFO ABOUT THREADS KILL'D AND SORT ABORTED
> MESSAGES

OK to push. One minor remark below.

[...]

> === modified file 'mysql-test/t/filesort_debug.test'
> --- a/mysql-test/t/filesort_debug.test	2011-02-02 11:54:49 +0000
> +++ b/mysql-test/t/filesort_debug.test	2011-02-23 14:26:23 +0000
> @@ -1,4 +1,6 @@
>   --source include/have_debug.inc
> +--source include/have_debug_sync.inc
> +--source include/count_sessions.inc
>
>   SET @old_debug= @@session.debug;
>
> @@ -21,3 +23,36 @@ DELETE FROM t1 ORDER BY (f1(10)) LIMIT 1
>
>   DROP TABLE t1;
>   DROP FUNCTION f1;
> +
> +--echo #
> +--echo # Bug #11747102
> +--echo # 30771: LOG MORE INFO ABOUT THREADS KILL'D AND SORT ABORTED MESSAGES
> +--echo #
> +
> +connect (con1, localhost, root);
> +connect (con2, localhost, root);
> +
> +--echo # connection 1
> +connection con1;
> +CREATE TABLE t1(f0 int auto_increment primary key, f1 int);
> +INSERT INTO t1(f1) VALUES (0),(1),(2),(3),(4),(5);
> +
> +let $ID= `SELECT @id := CONNECTION_ID()`;
> +
> +SET DEBUG_SYNC='filesort_start SIGNAL filesort_started WAIT_FOR filesort_killed';
> +--send SELECT * FROM t1 ORDER BY f1 ASC, f0
> +
> +--echo # connection 2
> +connection con2;
> +let $ignore= `SELECT @id := $ID`;
> +SET DEBUG_SYNC='now WAIT_FOR filesort_started';
> +KILL @id;
> +SET DEBUG_SYNC='now SIGNAL filesort_killed';
> +
> +--echo # connection default
> +connection default;

I think its better to reap con1 before disconnecting, it avoids problem 
when running under embedded.

Regards,

Davi
Thread
bzr commit into mysql-5.5 branch (tor.didriksen:3354) Bug#11747102Tor Didriksen23 Feb
  • Re: bzr commit into mysql-5.5 branch (tor.didriksen:3354) Bug#11747102Davi Arnaut23 Feb
    • Re: bzr commit into mysql-5.5 branch (tor.didriksen:3354) Bug#11747102Tor Didriksen23 Feb
      • Re: bzr commit into mysql-5.5 branch (tor.didriksen:3354) Bug#11747102Davi Arnaut24 Feb