Hello,
On 02/21/2011 03:12 PM, Jorgen Loland wrote:
> 3692 Jorgen Loland 2011-02-21
> BUG#11762751: UPDATE STATEMENT THROWS AN ERROR, BUT STILL
> UPDATES THE TABLE ENTRIES (formerly 55385)
> BUG#11764529: MULTI UPDATE+INNODB REPORTS ER_KEY_NOT_FOUND
> IF A TABLE IS UPDATED TWICE (formerly 57373)
Patch approved.
Nice changeset comment!
Two code formatting suggestions below.
> === modified file 'sql/share/errmsg-utf8.txt'
> --- a/sql/share/errmsg-utf8.txt 2011-02-21 11:34:14 +0000
> +++ b/sql/share/errmsg-utf8.txt 2011-02-21 14:12:33 +0000
> @@ -6454,7 +6454,6 @@ ER_STMT_CACHE_FULL
> eng "Multi-row statements required more than 'max_binlog_stmt_cache_size'
> bytes of storage; increase this mysqld variable and try again"
> ER_BINLOG_STMT_CACHE_SIZE_GREATER_THAN_MAX
> eng "Option binlog_stmt_cache_size (%lu) is greater than
> max_binlog_stmt_cache_size (%lu); setting binlog_stmt_cache_size equal to
> max_binlog_stmt_cache_size."
> -
> ER_CANT_UPDATE_TABLE_IN_CREATE_TABLE_SELECT
> eng "Can't update table '%-.192s' while '%-.192s' is being created."
>
Unless you want to clean up the whole file, I'd suggest to revert
this change ;-)
> === modified file 'sql/sql_update.cc'
> --- a/sql/sql_update.cc 2010-12-29 00:38:59 +0000
> +++ b/sql/sql_update.cc 2011-02-21 14:12:33 +0000
> +static
> +bool unsafe_key_update(TABLE_LIST *leaves, table_map tables_for_update)
There's a trailing space after 'static'.
Thanks,
--- Jon Olav
