Hi Olav and Jon Olav,
On 02/21/2011 10:24 AM, Jon Olav Hauglid wrote:
> Hello,
>
> On 02/20/2011 08:14 PM, Olav Sandstaa wrote:
>> Hi Jørgen,
>>
>> Thanks for fixing this bug and for a very well commented commit message.
>> The solution looks correct. I have only two minor comments. Feel free to
>> ignore them if you do not agree.
>
> I agree with both Olav's comments.
Me to :)
> Further, I wonder if we just can't do an early exit when
> context->select_lex->first_natural_join_processing is false.
I am unsure because name_resolution_context is set at the end of this function.
Since I don't fully apprehend this part of the code I think it's safer to leave
it as it is.
--
Jørgen Løland | Senior Software Engineer | +47 73842138
Oracle MySQL
Trondheim, Norway
