From: Dmitry Lenev
Date: February 21 2011 11:02am
Subject: Re: bzr commit into mysql-5.5 branch (jon.hauglid:3350)
 Bug#11754461
List-Archive: http://lists.mysql.com/commits/131732
Message-Id: <20110221110225.GA4989@bandersnatch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Hello, Jon Olav!

* Jon Olav Hauglid <jon.hauglid@stripped> [11/02/21 13:42]:
> #At file:///export/home/x/mysql-5.5-bug11754461/ based on revid:sergey.vojtovich@stripped
> 
>  3350 Jon Olav Hauglid	2011-02-21
>       Bug #11754461 CANNOT ALTER TABLE WHEN KEY PREFIX TOO LONG
>       
>       The problem was that doing ALTER TABLE on a table which had a key
>       on a TEXT/BLOB column with a prefix longer than the minimum number
>       of characteres (as per the character set), by mistake caused an error.
>       (Error 1170 - ER_BLOB_KEY_WITHOUT_LENGTH).

IMO, the above comment can be made more clear by adjusting in the
following way:

The problem was that doing ALTER TABLE on a table which had a key
on a TEXT/BLOB column with a prefix longer than the maximum number
of characters in this column (as per the character set), by mistake,
caused an error (Error 1170 - ER_BLOB_KEY_WITHOUT_LENGTH).

What do you think?

>       
>       This bug not repeatable in 5.5.
>       
>       This patch adds a regression test to alter_table.test and
>       contains no code changes.

Otherwise, I am OK with your patch and think that it can be pushed.

-- 
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com

Are you MySQL certified?  http://www.mysql.com/certification