List:Commits« Previous MessageNext Message »
From:Øystein Grøvlen Date:February 21 2011 9:18am
Subject:Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326
View as plain text  
On 02/18/2011 01:22 PM, Olav Sandstaa wrote:
> Hi,
>
> Thanks for fixing this problem with the best_ref[] array not keeping its
> sort order.
>
> The changes look fine and I have only some minor comments (see inline).
>
> I understand why you have introduced the large "perl generator" for
> testing this. I think it is a good idea but I do not quite like that the
> "failure criterion" will be a test timeout. Unfortunately I do not have
> any other or better suggestions for how to make such a test. This has
> also increased the time for running the greedy_optimizer test from less
> than 1 second to almost 1 minute. Some things to consider: will
> "pruning" some of the generated test cases help? or maybe move this to a
> new separate test? I leave you to decide and if nobody else have
> objections it is fine to keep it as it is.

I think a 1 minute test is to long for main suite.  I suggest either to 
mark it as big (then it is run when supplying the --big option to mtr, 
and weekly? in pushbuild.)

--
Øystein

>
> OK to push when you have looked at the minor comments (mostly on coding
> style).
>
> Olav

Thread
bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326Ole John Aske31 Jan
  • Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326Olav Sandstaa18 Feb
    • Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326Ole John Aske18 Feb
    • Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326Øystein Grøvlen21 Feb
      • Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326Ole John Aske22 Feb