List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:February 18 2011 2:48pm
Subject:bzr commit into mysql-trunk branch (guilhem.bichot:3343)
View as plain text  
#At file:///home/mysql_src/bzrrepos_new/mysql-next-mr-opt-backporting/ based on revid:roy.lyseng@stripped

 3343 Guilhem Bichot	2011-02-18
      Code cleanup: during development in a feature tree, when adding
      one function which took a "const CHARSET_INFO *" parameter and passed
      it to String::set_charset(), it appears that String::set_charset()
      has only a CHARSET_INFO* parameter, causing a compilation problem.
      In the present patch, we change String::set_charset() to accept
      "const CHARSET_INFO*" instead.
      Thus String::charset() has to return this type too. As the return
      value of String::charset() is used as parameter in calls to constructors
      of Field descendants, those constructors have to accept
      "const CHARSET_INFO*" instead of CHARSET_INFO*. The patch fixes all
      those "dependencies". After it, "const CHARSET_INFO*" is more frequent
      in code than "CHARSET_INFO*", which is normal as most code needn't
      update the content of any CHARSET_INFO structure. This now gives the
      charset-managing code guarantees that users of charsets won't change
      their content.
      Copyrights are updated to match recommendations:
      last year = 2011; Oracle; but also (c) (not (C)), and the correct
      FSF address (Franklin Street, and FSF has "Inc.").

    modified:
      client/mysql.cc
      client/sql_string.cc
      client/sql_string.h
      include/ft_global.h
      include/m_ctype.h
      include/my_global.h
      include/my_handler.h
      include/my_sys.h
      include/my_tree.h
      include/mysql/plugin_audit.h.pp
      include/mysql/plugin_auth.h.pp
      include/mysql/plugin_ftparser.h
      include/mysql/plugin_ftparser.h.pp
      libmysqld/lib_sql.cc
      mysys/charset.c
      mysys/mf_qsort.c
      mysys/my_handler.c
      mysys/tree.c
      regex/debug.c
      regex/debug.ih
      regex/engine.c
      regex/engine.ih
      regex/my_regex.h
      regex/regcomp.c
      regex/regcomp.ih
      regex/reginit.c
      sql/event_data_objects.cc
      sql/event_db_repository.cc
      sql/field.cc
      sql/field.h
      sql/field_conv.cc
      sql/filesort.cc
      sql/gstream.h
      sql/handler.h
      sql/item.cc
      sql/item.h
      sql/item_cmpfunc.cc
      sql/item_cmpfunc.h
      sql/item_create.cc
      sql/item_create.h
      sql/item_func.cc
      sql/item_func.h
      sql/item_strfunc.cc
      sql/item_strfunc.h
      sql/item_sum.cc
      sql/item_sum.h
      sql/item_timefunc.cc
      sql/item_timefunc.h
      sql/item_xmlfunc.cc
      sql/key.cc
      sql/log.cc
      sql/log.h
      sql/log_event.cc
      sql/log_event.h
      sql/my_decimal.cc
      sql/my_decimal.h
      sql/procedure.h
      sql/protocol.cc
      sql/protocol.h
      sql/rpl_utility.cc
      sql/set_var.cc
      sql/set_var.h
      sql/sp.cc
      sql/sp.h
      sql/sp_head.cc
      sql/sp_head.h
      sql/sql_acl.cc
      sql/sql_audit.h
      sql/sql_base.cc
      sql/sql_class.cc
      sql/sql_class.h
      sql/sql_db.cc
      sql/sql_db.h
      sql/sql_delete.cc
      sql/sql_error.cc
      sql/sql_error.h
      sql/sql_lex.cc
      sql/sql_lex.h
      sql/sql_load.cc
      sql/sql_parse.cc
      sql/sql_parse.h
      sql/sql_partition.cc
      sql/sql_partition.h
      sql/sql_prepare.cc
      sql/sql_select.cc
      sql/sql_select.h
      sql/sql_show.cc
      sql/sql_signal.cc
      sql/sql_sort.h
      sql/sql_string.cc
      sql/sql_string.h
      sql/sql_table.cc
      sql/sql_table.h
      sql/sql_time.cc
      sql/sql_time.h
      sql/sql_trigger.cc
      sql/sql_yacc.yy
      sql/strfunc.cc
      sql/strfunc.h
      sql/sys_vars.h
      sql/table.cc
      sql/table.h
      sql/thr_malloc.cc
      sql/thr_malloc.h
      sql/uniques.cc
      storage/heap/hp_hash.c
      storage/innobase/handler/ha_innodb.cc
      storage/myisam/ft_boolean_search.c
      storage/myisam/ft_nlq_search.c
      storage/myisam/ft_parser.c
      storage/myisam/ft_static.c
      storage/myisam/ft_update.c
      storage/myisam/ftdefs.h
      storage/myisam/mi_key.c
      strings/ctype-big5.c
      strings/ctype-bin.c
      strings/ctype-cp932.c
      strings/ctype-czech.c
      strings/ctype-euc_kr.c
      strings/ctype-eucjpms.c
      strings/ctype-gb2312.c
      strings/ctype-gbk.c
      strings/ctype-latin1.c
      strings/ctype-mb.c
      strings/ctype-simple.c
      strings/ctype-sjis.c
      strings/ctype-tis620.c
      strings/ctype-uca.c
      strings/ctype-ucs2.c
      strings/ctype-ujis.c
      strings/ctype-utf8.c
      strings/ctype-win1250ch.c
      strings/ctype.c
      strings/my_strchr.c
      strings/my_vsnprintf.c

Diff too large for email (11063 lines, the limit is 10000).
No bundle (reason: no diff => no bundle).
Thread
bzr commit into mysql-trunk branch (guilhem.bichot:3343) Guilhem Bichot18 Feb