From: Ole John Aske
Date: February 18 2011 12:34pm
Subject: Re: bzr commit into mysql-trunk branch (ole.john.aske:3550) Bug#59326
List-Archive: http://lists.mysql.com/commits/131618
Message-Id: <4D5E6745.9080704@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 02/18/11 01:22 PM, Olav Sandstaa wrote:
> Hi,
>
> Thanks for fixing this problem with the best_ref[] array not keeping its sort order.
>
> The changes look fine and I have only some minor comments (see inline).
>
> I understand why you have introduced the large "perl generator" for testing this. I think it is a good idea but I do not
> quite like that the "failure criterion" will be a test timeout. Unfortunately I do not have any other or better
> suggestions for how to make such a test. This has also increased the time for running the greedy_optimizer test from
> less than 1 second to almost 1 minute. Some things to consider: will "pruning" some of the generated test cases help? or
> maybe move this to a new separate test? I leave you to decide and if nobody else have objections it is fine to keep it
> as it is.
>

It should not be necessary to execute the perl generated query for all table count 1..62.

I will likely change this in the final commit+push to only execute the largest of the
generated query.

Ole John