From: Frazer Clement
Date: February 15 2011 12:40pm
Subject: Re: bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3210)
List-Archive: http://lists.mysql.com/commits/131327
Message-Id: <4D5A7450.2050203@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Ok

Magnus Blåudd wrote:
> On 02/15/2011 12:24 PM, Frazer Clement wrote:
>> This change is to finally 'deprecate' the old format?
> 
> No. Just to create the correct schema for mysql.ndb_binlog_index in 5.5.
> 
> 
> You mean that we should _also_ remove the code in 
> ha_ndbcluster_binlog.cc that checks if the ndb_binlog_index has more 
> than 7 fields?
> 
> ha_ndbcluster_binlog.cc:
> static int
> ndb_binlog_index_table__write_rows(THD *thd,
>                                    ndb_binlog_index_row *row)
> {
> <snip>
>     if (ndb_binlog_index->s->fields > 7)
>                          ^^^^^^^^^^^^^^
> 
> 
> Well, in that case we should probably also check that ndb_binlog_index 
> has y the schema we require and return an error from ndb_binlog_init in 
> case it's not correct. So it's more things required to make this work 
> well. I think...
> 
> Please put it on a TODO.
> 
> / Magnus
> 
>>
>> Magnus Blåudd wrote:
>>> #At file:///home/msvensson/mysql/5.5-telco-7.0/ based on
>>> revid:magnus.blaudd@stripped
>>>
>>> 3210 Magnus Blåudd 2011-02-15
>>> ndb
>>> - the mysql.ndb_binlog_index has new layout
>>> - add code to update to new schema for ndb_binlog_index to
>>> mysql_system_tables_fix.sql and put the new table definition
>>> in mysql_system_tables.sql
>>>
>>> modified:
> 
> 


-- 
Frazer Clement, Senior Software Engineer,
MySQL Cluster / Oracle - www.mysql.com
Office: Edinburgh, UK

Are you MySQL certified?  www.mysql.com/certification