List:Commits« Previous MessageNext Message »
From:Øystein Grøvlen Date:February 14 2011 10:48am
Subject:Re: bzr commit into mysql-trunk branch (roy.lyseng:3342) Bug#11766669
View as plain text  
Approved.  Just one suggestion below.

On 02/14/11 11:31 AM, Roy Lyseng wrote:
> #At file:///home/rl136806/mysql/repo/mysql-work5/ based on
> revid:jorgen.loland@stripped
>
>   3342 Roy Lyseng	2011-02-14
>        Bug#11766669: materialization=on/off leads to different result set when using
> IN
>

...

> @@ -9634,22 +9641,34 @@ static bool make_join_select(JOIN *join,
>       /*
>         Step #2: Extract WHERE/ON parts
>       */
> +    table_map used_tables= 0;
>       table_map save_used_tables= 0;
> -    used_tables= join->const_table_map | OUTER_REF_TABLE_BIT | RAND_TABLE_BIT;
> -    JOIN_TAB *tab;
> -    table_map current_map;
>       for (uint i=join->const_tables ; i<  join->tables ; i++)
>       {
> -      tab= join->join_tab+i;
> +      JOIN_TAB *tab= join->join_tab+i;
>         /*

I suggest to a spaces around + above.

--
Øystein
Thread
bzr commit into mysql-trunk branch (roy.lyseng:3342) Bug#11766669Roy Lyseng14 Feb
  • Re: bzr commit into mysql-trunk branch (roy.lyseng:3342) Bug#11766669Øystein Grøvlen14 Feb