List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:February 11 2011 2:26pm
Subject:Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724
View as plain text  
Roy Lyseng skrev 2011-02-11 14.46:
> Hi Martin,
>
> thank you for this patch. I have now revisited all code, and AFAIK 
> things look good. I have some minor suggestions that you need to 
> consider, though.
Oh no! You shouldn't have... ;-) As I told you on IRC the central 
algorithm is all wrong. I finished a new patch this morning but I 
haven't committed because Omer said in the conf call last night that we 
should not do anything that might upset bugs.mysql.com today. Such as 
commits, apparently...

Anyway, thank you for the comments, most of them seem independent of the 
changes in the new patch so I'll incorporate them as well. And be ready 
for yet another mid-size change next week!

Have a nice weekend!

/Martin
Thread
Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Roy Lyseng11 Feb
  • Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Martin Hansson11 Feb
    • Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Roy Lyseng11 Feb
  • Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Martin Hansson16 Feb
    • Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Roy Lyseng21 Feb
      • Re: bzr commit into mysql-trunk branch (martin.hansson:3272) WL#3724Martin Hansson16 Mar