List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:February 10 2011 9:05pm
Subject:Re: bzr commit into mysql-5.5-bugteam branch (joerg:3212) Bug#42969
View as plain text  
Hello,

Joerg Bruehe a écrit, Le 07.02.2011 12:50:
> #At file:///MySQL/REPO/V55/bug42969-5.5/ based on
> revid:joerg@stripped
> 
>  3212 Joerg Bruehe	2011-02-07
>       Bug #42969  	Please add a MANIFEST to each build
>       
>       First attempt at a test that will verify the existence
>       of both "INFO_SRC" and "INFO:_BIN", as well as (some of)
>       their expected (invariant) contents.
>       

> +open(I_SRC,"<","$dir_docs/INFO_SRC") or print "Cannot open 'INFO_SRC' in
> '$dir_docs'\n";
> +while(defined ($line = <I_SRC>)) {
> +  if ($line =~ m|^MySQL source \d\.\d\.\d+|) {$found_version = "Found MySQL version
> number";}
> +  if ($line =~ m|^revision-id: |) {$found_revision = "Found BZR revision id";}

Can we make the pattern above more specic, to verify that in the 
revision-id line we have '@' and '-2', as in
joerg@stripped
?
The interest is making sure that it's really a bzr revision-id which the 
  cmake commands put in INFO_SRC, and not some wrong data.


> +}
> +close I_SRC;
> +print "INFO_SRC: $found_version / $found_revision\n";
> +$found_compiler = "No line 'Compiler flags'";
> +$found_features = "No line 'Feature flags'";
> +open(I_BIN,"<","$dir_docs/INFO_BIN") or print "Cannot open 'INFO_BIN' in
> '$dir_docs'\n";
> +while(defined ($line = <I_BIN>)) {
> +  if ($line =~ m| Compiler flags used |) {$found_compiler = "Found 'Compiler flags'
> line";}

here we don't search for ':'

> +  if ($line =~ m| Feature flags used:|) {$found_features = "Found 'Feature flags'
> line";}

here we do?

The rest looks quite good.
Thread
bzr commit into mysql-5.5-bugteam branch (joerg:3212) Bug#42969Joerg Bruehe7 Feb
  • Re: bzr commit into mysql-5.5-bugteam branch (joerg:3212) Bug#42969Guilhem Bichot10 Feb
    • Re: bzr commit into mysql-5.5-bugteam branch (joerg:3212) Bug#42969Joerg Bruehe10 Feb