List:Commits« Previous MessageNext Message »
From:Gleb Shchepa Date:February 10 2011 4:20pm
Subject:Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315)
Bug#59894
View as plain text  
Hello Guilhem,

Sorry, you are correct. Please ignore that message.

Thank you,
Gleb.

On 02/10/2011 07:03 PM, Guilhem Bichot wrote:
> Hello Gleb,
>
> Gleb Shchepa a écrit, Le 10.02.2011 16:58:
>> Hello Guilhem,
>>
>> The patch looks good, but a few find_type() calls are not modified, please see
> sql/sql_plugin.cc, sql/item_func.cc, sql/sql_base.cc, sql/table.cc and sql/strfunc.cc.
>
> this is normal: they are not the same find_type() function.
> The bug is about mysys' find_type() (takes 3 arguments), not about sql's find_type()
> (takes 4 arguments). All calls to mysys' find_type(), and only them, have been changed.
>
>> The last file even has a funny call convention: find_type(lib, start, var_len,
> (bool) 0) ;-)
>
> Yes, this function takes a bool as 4th argument.
>
>>
>> Thank you,
>> Gleb
>>
>>
>> On 02/10/2011 04:58 PM, Guilhem Bichot wrote:
>>> [This commit e-mail is a repeat.]
>>>
>>> #At file:///home/mysql_src/bzrrepos_new/5.5-bugteam/ based on
> revid:anitha.gopi@stripped
>

Thread
[Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315) Bug#59894Guilhem Bichot10 Feb
  • Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315) Bug#59894Tor Didriksen10 Feb
    • Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315)Bug#59894Guilhem Bichot10 Feb
  • Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315)Bug#59894Gleb Shchepa10 Feb
    • Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315)Bug#59894Guilhem Bichot10 Feb
      • Re: [Resend] bzr commit into mysql-5.5 branch (guilhem.bichot:3315)Bug#59894Gleb Shchepa10 Feb