You have re-formatted the header in mysqldump.c (and some other files)
The first sentence *has* to be on one line.
There is no benefit of re-formatting the rest?
(oh, I see the street address has actually changed :-)
in case you are an emacs'er, here's the snippet i use:
(setq mysql-copyright-notice "\
/* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
(defun insert-mysql-copyright-notice ()
"Insert standard copyright header."
The doxygen comment for typelib still says 'lib'
int find_type(const char *x, const TYPELIB *typelib, uint flags)
I also suggest splitting one line in the comment:
@param flags flags to tune behaviour: a combination of
FIND_TYPE_NO_OVERWRITE can be
passed but is superfluous (is always implicitely
I also think you can safely remove the register assignments for i and j.