List:Commits« Previous MessageNext Message »
From:Tatjana Azundris Nuernberg Date:February 10 2011 8:27am
Subject:Re: bzr commit into mysql-5.5-bugteam branch (azundris:3229) Bug#48388
View as plain text  
Hi Jon Olav,

Thanks for the review!

 > Looks like you've made the patch for 5.5?
 > I've checked with Staale and it should go to trunk.

As discussed went by target version on ticket. Updated version is vs 
trunk. I've also amended the mysqld--help...include to eliminate a race 
condition.

 >> @@ -1416,6 +1421,7 @@ void clean_up(bool print_message)
 >> make sure that handlers finish up
 >> what they have that is dependent on the binlog
 >> */
 >> + sql_print_information("binlog end");

I usually find it wise to err on the side of too much rather than too 
little info, but I'm hardly married to this one. :)

 > I guess I can see the point of adding this notice even if it wasn't part
 > of the original feature request as far as I can see. Has there been a
 > discussion somewhere about adding additional notices?

This is it.

 >> === modified file 'sql/sql_plugin.cc'
 >> --- a/sql/sql_plugin.cc 2010-12-02 07:16:26 +0000
 >> +++ b/sql/sql_plugin.cc 2011-01-20 11:47:44 +0000
 >> @@ -957,7 +957,10 @@ static void reap_plugins(void)
 >>
 >> list= reap;
 >> while ((plugin= *(--list)))
 >> + {
 >> + sql_print_information("Shutting down plugin '%s'", plugin->name.str);
 >> plugin_deinitialize(plugin, true);
 >> + }
 >
 > Same comment here as for "binlog end".

This pretty much /is/ the implementation.
This part is generic; if a plugin doesn't give any updates by itself, we 
can at least tell in which plugin we get stuck. The plugin can of course 
supplement these stark enter/exit messages with more meaningful info. I 
was printing an excerpt of SHOW ENGINE INNODB STATUS during lengthy inno 
shutdowns specifically (that being the engine the customer seemed most 
interested in), but now that the feature is targeted at 5.6 rather than 
5.5, I don't really have to do that anymore: inno in 5.6 implements just 
that, anyway.

Anyway, with these here wrapper messages, at least the user can see 
progress, plus of course, it's more obvious to them if the long delay 
happens in a third party plugin that does not itself give status updates.

thanks and regards,
Azundris


-- 
Tatiana Azundris, Bugs Bunny * IRC/Skype: Azundris * azundris@stripped

ORACLE Deutschland B.V. & Co. KG - http://oracle.com
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschaftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Oracle is committed to developing practices and products that help
protect the environment - http://www.oracle.com/commitment

Thread
bzr commit into mysql-5.5-bugteam branch (azundris:3229) Bug#48388Tatiana Azundris Nurnberg20 Jan
  • Re: bzr commit into mysql-5.5-bugteam branch (azundris:3229) Bug#48388Jon Olav Hauglid2 Feb
    • Re: bzr commit into mysql-5.5-bugteam branch (azundris:3229) Bug#48388Tatjana Azundris Nuernberg10 Feb
      • Re: bzr commit into mysql-5.5-bugteam branch (azundris:3229) Bug#48388Jon Olav Hauglid10 Feb