From: Dmitry Shulga
Date: February 9 2011 3:31pm
Subject: Re: bzr push into mysql-5.5 branch (Dmitry.Shulga:3320 to 3321) Bug#57450
List-Archive: http://lists.mysql.com/commits/130893
Message-Id: <30F63978-C8F2-48D9-BCC3-3B81D1078BB0@oracle.com>
MIME-Version: 1.0 (Apple Message framework v1082)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable


On 09.02.2011, at 21:09, Vladislav Vaintroub wrote:

> Hi Dmitry,=20
Hi Vladislav!

> With  my_fstat() you need my_fileno(), my_fopen(), my_fclose() etc , =
i.e
> consistent usage of  my_  prefix.  If you use fileno() here, it  will
> assert  in my_get_osfhandle() inside my_win_fstat() - it does not like =
the
> mix of CRT file descriptors and the ones returned by my_winfile.c
You are right.
But it doesn't matter because I decided to put this 'if' statement =
inside #ifdef __WIN__ since MY_S_ISBLK doesn't make sense on Windows.
So on Windows mysqld will successfully open a directory and then get an =
error when reading from it.=20

Regards, Dmitry.

>=20
>> LINE_BUFFER *batch_readline_init(ulong max_size,FILE *file)
>> {
>>   LINE_BUFFER *line_buff;
>> +  MY_STAT input_file_stat;
>> +
>> +  if (my_fstat(fileno(file), &input_file_stat, MYF(MY_WME)) ||
>=20
>=20
>=20
>=20
>=20