From: Vladislav Vaintroub
Date: February 9 2011 3:09pm
Subject: RE: bzr push into mysql-5.5 branch (Dmitry.Shulga:3320 to 3321) Bug#57450
List-Archive: http://lists.mysql.com/commits/130885
Message-Id: <028801cbc86b$574fe220$05efa660$@montyprogram.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit



> -----Original Message-----
> From: Dmitry Shulga [mailto:Dmitry.Shulga@stripped]
> Sent: Mittwoch, 9. Februar 2011 07:59
> To: commits@stripped
> Subject: bzr push into mysql-5.5 branch (Dmitry.Shulga:3320 to 3321)
> Bug#57450

Hi Dmitry, 
With  my_fstat() you need my_fileno(), my_fopen(), my_fclose() etc , i.e
consistent usage of  my_  prefix.  If you use fileno() here, it  will
assert  in my_get_osfhandle() inside my_win_fstat() - it does not like the
mix of CRT file descriptors and the ones returned by my_winfile.c

>  LINE_BUFFER *batch_readline_init(ulong max_size,FILE *file)
>  {
>    LINE_BUFFER *line_buff;
> +  MY_STAT input_file_stat;
> +
> +  if (my_fstat(fileno(file), &input_file_stat, MYF(MY_WME)) ||