List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:February 9 2011 11:40am
Subject:Re: bzr commit into mysql-5.5 branch (Georgi.Kodinov:3234)
Bug#59017
View as plain text  
Hi Joro,

if you really want to rename the plugin - that's ok. But I have
a few questions about the problem.

I assume that when the name "socket_peercred" was initially suggested,
things used to work. What has changed, so it doesn't load anymore?

As far as I remember semantics of system variables is as following:
if plugin variable conflicts with server variable, server variable
wins. Still plugin variable may be referenced as "--plugin-...".
If this rule still applies, do we agree that there is something
wrong and are we going to fix what went wrong?

More interesting, you say that "socket_peercred" conflicting with
"socket". But this way why "flush" is not conflicting with "flush_time",
"old" is not conflicting with "old_alter_table", "shared_memory" is
not conflicting with "shared_memory_base_name", etc?

Regards,
Sergey

On Tue, Jan 11, 2011 at 02:53:19PM +0000, Georgi Kodinov wrote:
> #At file:///Users/kgeorge/mysql/work/B59017-5.5/ based on
> revid:magne.mahre@stripped
> 
>  3234 Georgi Kodinov	2011-01-11
>       Bug #59017: Auth plugin socket_peercred fails to load in 5.5.8
>       
>       Due to how the server checks for option names the name of the
>       plugin "socket_peercred" collides with the existing server side 
>       option "socket".
>       
>       Renamed the plugin from "socket_peercred" to "auth_socket" to
>       avoid the name clash.
> 
>     modified:
>       plugin/auth/auth_socket.c
> === modified file 'plugin/auth/auth_socket.c'
> --- a/plugin/auth/auth_socket.c	2010-09-20 16:38:27 +0000
> +++ b/plugin/auth/auth_socket.c	2011-01-11 14:53:14 +0000
> @@ -79,7 +79,7 @@ mysql_declare_plugin(socket_auth)
>  {
>    MYSQL_AUTHENTICATION_PLUGIN,
>    &socket_auth_handler,
> -  "socket_peercred",
> +  "auth_socket",
>    "Sergei Golubchik",
>    "Unix Socket based authentication",
>    PLUGIN_LICENSE_GPL,
> 


> 
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1


-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.5 branch (Georgi.Kodinov:3234) Bug#59017Georgi Kodinov11 Jan
  • Re: bzr commit into mysql-5.5 branch (Georgi.Kodinov:3234)Bug#59017Sergey Vojtovich9 Feb
Re: bzr commit into mysql-5.5 branch (Georgi.Kodinov:3234)Bug#59017Sergey Vojtovich10 Feb