bk commit into 5.0 tree (iggy:1.2291) BUG#19024

[Ignacio Galarza]

Below is the list of changes that have just been committed into a local
5.0 repository of iggy. When iggy does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-04 10:49:39-04:00, iggy@stripped +3 -0
  Bug #19024- SHOW COUNT(*) WARNINGS not return Errors
    
  The server variable warning_count should include the number of warnings, errors and
notes according to the manual

  mysql-test/r/user_var.result@stripped, 2006-10-04 10:49:37-04:00,
iggy@stripped +9 -0
    Added warning_count results.

  mysql-test/t/user_var.test@stripped, 2006-10-04 10:49:37-04:00,
iggy@stripped +9 -1
    Added test case for warning_count.

  sql/set_var.cc@stripped, 2006-10-04 10:49:37-04:00, iggy@stripped +1 -0
    Added number errors to warning_count.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	iggy
# Host:	rolltop.ignatz42.dyndns.org
# Root:	/mnt/storeage/bug19024/my50-bug19024

--- 1.163/sql/set_var.cc	2006-10-04 10:49:44 -04:00
+++ 1.164/sql/set_var.cc	2006-10-04 10:49:44 -04:00
@@ -2917,6 +2917,7 @@
 {
   thd->sys_var_tmp.long_value=
     (thd->warn_count[(uint) MYSQL_ERROR::WARN_LEVEL_NOTE] +
+     thd->warn_count[(uint) MYSQL_ERROR::WARN_LEVEL_ERROR] +
      thd->warn_count[(uint) MYSQL_ERROR::WARN_LEVEL_WARN]);
   return (byte*) &thd->sys_var_tmp.long_value;
 }

--- 1.42/mysql-test/r/user_var.result	2006-10-04 10:49:44 -04:00
+++ 1.43/mysql-test/r/user_var.result	2006-10-04 10:49:44 -04:00
@@ -215,6 +215,7 @@
 select @@global.version;
 @@global.version
 #
+End of 4.1 tests
 set @first_var= NULL;
 create table t1 select @first_var;
 show create table t1;
@@ -301,3 +302,11 @@
 @var
 3
 drop table t1;
+insert into city 'blah';
+ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to
your MySQL server version for the right syntax to use near ''blah'' at line 1
+SHOW COUNT(*) WARNINGS;
+@@session.warning_count
+1
+SHOW COUNT(*) ERRORS;
+@@session.error_count
+1

--- 1.37/mysql-test/t/user_var.test	2006-10-04 10:49:44 -04:00
+++ 1.38/mysql-test/t/user_var.test	2006-10-04 10:49:44 -04:00
@@ -144,6 +144,8 @@
 --replace_column 1 #
 select @@global.version;
 
+--echo End of 4.1 tests
+
 # Bug #6598: problem with cast(NULL as signed integer);
 #
 
@@ -210,4 +212,10 @@
 select @var;
 drop table t1;
 
-# End of 4.1 tests
+#
+# Bug#19024 - SHOW COUNT(*) WARNINGS not return Errors 
+#
+--error 1064
+insert into city 'blah';
+SHOW COUNT(*) WARNINGS;
+SHOW COUNT(*) ERRORS;