From: Inaam Rana
Date: February 7 2011 11:53pm
Subject: bzr commit into mysql-trunk-innodb branch (inaam.rana:3486) Bug#59472
List-Archive: http://lists.mysql.com/commits/130646
X-Bug: 59472
Message-Id: <20110207235331.6BA03C41DE@bling>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1183038008=="

--===============1183038008==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///home/inaam/w/mysql-trunk-innodb/ based on revid:marko.makela@stripped

 3486 Inaam Rana	2011-02-07 [merge]
      Bug #59472 increase AIO requests per IO thread limit to 256 from 32
      Merged from mysql-5.5-innodb -r3309
      
        rb://566
        approved by: Sunny
        
        When using native aio on linux each IO helper thread should be able to
        handle upto 256 IO requests. The number 256 is the same which is used
        for simulated aio as well. In case of windows where we also use native
        aio this limit is 32 because of OS constraints. It seems that we are
        using the limit of 32 for all the platforms where we are using native
        aio. The fix is to use 256 on all platforms except windows (when native
        aio is enabled on windows)

    modified:
      storage/innobase/srv/srv0start.c
=== modified file 'storage/innobase/srv/srv0start.c'
--- a/storage/innobase/srv/srv0start.c	revid:marko.makela@stripped
+++ b/storage/innobase/srv/srv0start.c	revid:inaam.rana@stripped
@@ -1327,13 +1327,16 @@ innobase_start_or_create_for_mysql(void)
 
 	ut_a(srv_n_file_io_threads <= SRV_MAX_N_IO_THREADS);
 
-	/* TODO: Investigate if SRV_N_PENDING_IOS_PER_THREAD (32) limit
-	still applies to windows. */
-	if (!srv_use_native_aio) {
-		io_limit = 8 * SRV_N_PENDING_IOS_PER_THREAD;
-	} else {
+	io_limit = 8 * SRV_N_PENDING_IOS_PER_THREAD;
+
+	/* On Windows when using native aio the number of aio requests
+	that a thread can handle at a given time is limited to 32
+	i.e.: SRV_N_PENDING_IOS_PER_THREAD */
+# ifdef __WIN__
+	if (srv_use_native_aio) {
 		io_limit = SRV_N_PENDING_IOS_PER_THREAD;
 	}
+# endif /* __WIN__ */
 
 	os_aio_init(io_limit,
 		    srv_n_read_io_threads,


--===============1183038008==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/inaam.rana@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: inaam.rana@stripped
# target_branch: file:///home/inaam/w/mysql-trunk-innodb/
# testament_sha1: c361043439afa02f1578b8cea7a202710bbc4e14
# timestamp: 2011-02-07 18:53:31 -0500
# source_branch: bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-\
#   5.5-innodb/
# base_revision_id: marko.makela@stripped\
#   7jbzaxdi3q6i53nm
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWeG/AmwAA+JfgAAwWnP//3fj
3YC////4YAgvg0pVBVKAbYUKkABUJUiZGho0GmmAgAAaNDQAAAklGqe0ZMphGSYkeptT1HqaaBoB
poAAc0ZMTABMRgRpgQYjBMmARhzRkxMAExGBGmBBiMEyYBGHNGTEwATEYEaYEGIwTJgEYJIgjQEG
Q0mQCYEhqNNNlP1Jo9Mp4okIo5mezjfxJmA/VkzrrIyQhKDAvUkQrJOqqMUUggsLPLldai4psbWS
mT7LroQtmVUk8F2QtwiI+JXs4Funn8ZczQyGGGR/z2R9IkbhxtrnDN2bxfeH0NxVD5mRqMJXWnve
6Ees1XH8mJieoXnpqPe7EQ57pytLTrJuSZyZYQIMGY0zqGUz2PucD1YqCop8/E2lud0/YtlQ1mJd
YYG4xIlY9xu6h5d7u4MrRjJi0uLB1ZA/A8vfeFQOIFhYOCwiVwKSgwgPJRIltZArBxySucmMRSYc
3Ejy5dnaH2IE8er17kEIul5mJ0ioDh56zZ6xZigvE5ALyFxPFa0FosBGRmeUv3k/CR5hVlBgYDDn
MNtqICoEJ6vrWsQeB+l3mcd28ibcL3d8cpJGYxz9CQjgRnzgIciSPEBdQniMJDNiVcRQ8OLu8xSm
RkVpIhTauqJQKpGmFwzoTKiXN2CjvFK9GDC5FhNhI7K/83nUHh1kAFuU4kiIt5RUsI35Y1ZkNQHL
cK8tsNH6NBGqJmLkK043HuFWt2Ww1V12U02l4YDCyzuz4fcXW8tramruaMAoagFpkJEFXph0jdFs
wC0iFdwEFQabuQ4F4VirM2S5HYMfsIpdbgXl2wQy1EFbNxGB116kphjwcKVUESGFtsIkrTgKFyxF
ITYmRYXdSi0qmWtRFQpEKhaWztioMWqsRqKT2FhAnEsjOtWUHMAki8lvFqODF5PcVig8dPnkKNUD
SpUmHE/bQKtOShaqzHeiImUqgORfOokLHf8DINLhTWMMBUNT2G92HqagFvRE71RTetDDza0hNIks
ShEVcSwHjhS1vtrF/F07Br5VEXrW3iOkERcrlIUsLFZGGowFhcSL8uu05qNl1+wVjqRbUKFe2qtZ
cFvtK54zpqJGsZ841mLFOqNgqVAc60hSSzsFGMx2NtR1QpGvvDTln4zMrsxHCp1YYkciQ2wUzWri
KJTICYrGmFEmJUGKCgv1/IyGG2HANpcdsGaB0HUdhiL8jzXJCPYvKGDMMDM0OR7HzPoT+gXCIn1M
z7FxQYPYYtGL7z6khhERhnD6n+yRE9hhhiQwaxx62c+p9jUUKiRAmbeYxyGS9m0+Ug4+pUVjrsPE
51gdon8pdMz8/QorRB6ScEfi8c1r/X7iE4vMRRXMfgRmTSvGLDmwm0d/JfvAWYIrMTQy5FoI0VtK
MG0RcqCgbSw4qUaJzYJi8RMzWpqUIiefjcRpdfJYiZE2QkYrZEV1hoFCkModBOPIbJe1WHwUzeIY
NYrzAvJ4mtwOMRY8chPmqjnFmLfp8yGB7jpGdjMQ4hfFxGYhcS8qOgWAdYxRhhhhtPA4QWGw2ah1
ajKgnOMhewjzDmLldQ6LdTi46K/xDgnEYFQi/pvXgutk28MSC5i0XgdzExkwMEAqFEwgCXYX88iB
8rVuJTOXz72wdDkTPJuIhRRpuIJad3A1IyY4cDYbCskWkemQ6orys7jEz4OVF5X0aHUV7txTi42H
9EA71zNCAxvZcVxCAmFwGRtO0Zjbz0KB+N8zuOoPJFoGBQUTUTO8NbKBgJvTvlppPKJwiLkcf488
PcWhh4RD7neZh2CO11BlYbwdOaEkpoNJa8haxN0ARLYr5DDDItcXHaMk4eMh4sz70rh5hG1TV3SN
iSP7iYrKV4sF60FJHqBFRJfycxskMOM/EicktRkwZWJaFsP6xMgRHjkK+sC0NQyWYHERiI8+oeS1
+BPEcwjo2JMdYjQtqVasDsTHSuoC8CA4FEMmR2nmDHXUe8ckIUAgW5oL0UOBQcriWn6C9SAyBMIN
ic+C5LaixY1BEcFuLRFZBSJBUXDETCI/yqP4K3KxMLZ2uEQRIqEEyiRtkRQRdOlMYDtMUveoJw2J
yRUIdMKixUAJB0dKUBDHEde5NJa6q0mWQJOKQHwIEVYH9CFak6Dm4sO40VR0pOXcRhhODnMqHCmW
8qIGZE3LnvUUFBq3HOgTGjEEAazmIOBh0vQKgyRvICJo1lQ4TOW2auQdav4KeYTFWVTS2ITifYdA
bxlAccVRFQGIhyGqMChwKxgYZQNe5kzYECSYklcBEoGjDbD9V+BHqeeAfmLBLWQQ6xvYYO4Yc3Ez
rF+0SA4ZgMQJ6zINZEPSAA5pYQvCIhy4ZFqVwmGkLfBQGKnFcZiPRNyR7zcTOgrViXaRUxXG6gDe
9DwVia9XCKRoi56AdKyS7rRMmO0XSOhbuIrkqy4sNa9zimXAwxIn4hWrNdcKlFQNH/F3JFOFCQ4b
8CbA


--===============1183038008==--