List:Commits« Previous MessageNext Message »
From:Inaam Rana Date:February 7 2011 11:45pm
Subject:bzr push into mysql-5.5-innodb branch (inaam.rana:3308 to 3309) Bug#59472
View as plain text  
 3309 Inaam Rana	2011-02-07
      Bug #59472 increase AIO requests per IO thread limit to 256 from 32
      
      rb://566
      approved by: Sunny
      
      When using native aio on linux each IO helper thread should be able to
      handle upto 256 IO requests. The number 256 is the same which is used
      for simulated aio as well. In case of windows where we also use native
      aio this limit is 32 because of OS constraints. It seems that we are
      using the limit of 32 for all the platforms where we are using native
      aio. The fix is to use 256 on all platforms except windows (when native
      aio is enabled on windows)

    modified:
      storage/innobase/srv/srv0start.c
 3308 Vasil Dimov	2011-02-07
      Add one more Valgrind suppression to cover a different codepath

    modified:
      mysql-test/valgrind.supp
=== modified file 'storage/innobase/srv/srv0start.c'
--- a/storage/innobase/srv/srv0start.c	revid:vasil.dimov@stripped
+++ b/storage/innobase/srv/srv0start.c	revid:inaam.rana@stripped
@@ -1327,13 +1327,16 @@ innobase_start_or_create_for_mysql(void)
 
 	ut_a(srv_n_file_io_threads <= SRV_MAX_N_IO_THREADS);
 
-	/* TODO: Investigate if SRV_N_PENDING_IOS_PER_THREAD (32) limit
-	still applies to windows. */
-	if (!srv_use_native_aio) {
-		io_limit = 8 * SRV_N_PENDING_IOS_PER_THREAD;
-	} else {
+	io_limit = 8 * SRV_N_PENDING_IOS_PER_THREAD;
+
+	/* On Windows when using native aio the number of aio requests
+	that a thread can handle at a given time is limited to 32
+	i.e.: SRV_N_PENDING_IOS_PER_THREAD */
+# ifdef __WIN__
+	if (srv_use_native_aio) {
 		io_limit = SRV_N_PENDING_IOS_PER_THREAD;
 	}
+# endif /* __WIN__ */
 
 	os_aio_init(io_limit,
 		    srv_n_read_io_threads,


Attachment: [text/bzr-bundle] bzr/inaam.rana@oracle.com-20110207234300-i2kdaduafjcmjcla.bundle
Thread
bzr push into mysql-5.5-innodb branch (inaam.rana:3308 to 3309) Bug#59472Inaam Rana8 Feb