List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:February 7 2011 10:21am
Subject:bzr commit into mysql-5.1-mtr branch (bjorn.munch:2980) Bug#59979
View as plain text  
#At file:///home/bm136801/my/dbsrv-51/ based on revid:bjorn.munch@stripped

 2980 Bjorn Munch	2011-02-07
      Bug #59979 Add mtr option to run debug server, but without turning on debug
      Added --debug-server and use $opt_debug_server where appropriate
      Let --debug imply --debug-server
      When merging to 5.5, must adapt fix for 59148

    modified:
      mysql-test/mysql-test-run.pl
=== modified file 'mysql-test/mysql-test-run.pl'
--- a/mysql-test/mysql-test-run.pl	2011-02-04 11:33:45 +0000
+++ b/mysql-test/mysql-test-run.pl	2011-02-07 10:19:44 +0000
@@ -182,6 +182,7 @@ my $opt_cursor_protocol;
 my $opt_view_protocol;
 
 our $opt_debug;
+our $opt_debug_server;
 our @opt_cases;                  # The test cases names in argv
 our $opt_embedded_server;
 
@@ -936,6 +937,7 @@ sub command_line_setup {
 
              # Debugging
              'debug'                    => \$opt_debug,
+             'debug-server'             => \$opt_debug_server,
              'gdb'                      => \$opt_gdb,
              'client-gdb'               => \$opt_client_gdb,
              'manual-gdb'               => \$opt_manual_gdb,
@@ -1101,6 +1103,9 @@ sub command_line_setup {
     mtr_print_thick_line('#');
   }
 
+  # --debug implies we run debug server
+  $opt_debug_server= 1 if $opt_debug;
+
   if ( @opt_experimentals )
   {
     # $^O on Windows considered not generic enough
@@ -1712,7 +1717,7 @@ sub find_mysqld {
   my @mysqld_names= ("mysqld", "mysqld-max-nt", "mysqld-max",
 		     "mysqld-nt");
 
-  if ( $opt_debug ){
+  if ( $opt_debug_server ){
     # Put mysqld-debug first in the list of binaries to look for
     mtr_verbose("Adding mysqld-debug first in list of binaries to look for");
     unshift(@mysqld_names, "mysqld-debug");
@@ -2402,9 +2407,9 @@ sub check_debug_support ($) {
     #mtr_report(" - binaries are not debug compiled");
     $debug_compiled_binaries= 0;
 
-    if ( $opt_debug )
+    if ( $opt_debug_server )
     {
-      mtr_error("Can't use --debug, binaries does not support it");
+      mtr_error("Can't use --debug[-server], binary does not support it");
     }
     return;
   }
@@ -5582,6 +5587,8 @@ Options for debugging the product
   client-gdb            Start mysqltest client in gdb
   ddd                   Start mysqld in ddd
   debug                 Dump trace output for all servers and client programs
+  debug-server          Use debug version of server, but without turning on
+                        tracing
   debugger=NAME         Start mysqld in the selected debugger
   gdb                   Start the mysqld(s) in gdb
   manual-debug          Let user manually start mysqld in debugger, before


Attachment: [text/bzr-bundle] bzr/bjorn.munch@oracle.com-20110207101944-02uob6e756k5xdp5.bundle
Thread
bzr commit into mysql-5.1-mtr branch (bjorn.munch:2980) Bug#59979Bjorn Munch7 Feb