List:Commits« Previous MessageNext Message »
From:kevin.lewis Date:February 4 2011 2:59pm
Subject:bzr commit into mysql-5.5-innodb branch (kevin.lewis:3303) Bug#59699
View as plain text  
#At file:///Users/kevinlewis/Work/Mysql/Bug59699/mysql-5.5-innodb/ based on revid:marko.makela@stripped

 3303 kevin.lewis@stripped	2011-02-04
      Bug#59699 - Hidden bug would cause a crash for unknown tablespace flags.
      
      The bug would cause a crash of InnoDB if a non-standard or unknown table
      flags existed in a SYS_TABLES record. This is important because the next
      file version, Cheetah, will identify itself by expanding this field.  So
      unless this is fixed, an older engine that tries to open a table in a
      tablespace with a newer file version will crash instead of report an error
      and refuse to open the table, as it should do.
      
      Reviewed at RB://583.    Approved by Marko.

    modified:
      storage/innobase/dict/dict0load.c
=== modified file 'storage/innobase/dict/dict0load.c'
--- a/storage/innobase/dict/dict0load.c	revid:marko.makela@stripped
+++ b/storage/innobase/dict/dict0load.c	revid:kevin.lewis@stripped
@@ -1552,7 +1552,7 @@ err_len:
 				"InnoDB: in InnoDB data dictionary"
 				" has unknown type %lx.\n",
 				(ulong) flags);
-			return(NULL);
+			return("incorrect flags in SYS_TABLES");
 		}
 	} else {
 		flags = 0;


Attachment: [text/bzr-bundle] bzr/kevin.lewis@oracle.com-20110204145930-jcymzrhjn0czsqww.bundle
Thread
bzr commit into mysql-5.5-innodb branch (kevin.lewis:3303) Bug#59699kevin.lewis4 Feb