List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:February 3 2011 11:31am
Subject:Re: bzr commit into mysql-next-mr-wl5569 branch
(andrei.elkin:3271) WL#5754
View as plain text  
On 03/02 09.28, Andrei Elkin wrote:
> === added file 'mysql-test/suite/rpl/t/rpl_parallel_multi_db.test'
> --- a/mysql-test/suite/rpl/t/rpl_parallel_multi_db.test	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/suite/rpl/t/rpl_parallel_multi_db.test	2011-02-03 09:28:27 +0000
> @@ -0,0 +1,123 @@
> +#
> +# WL#5569 MTS
> +#
> +# The test verifies correctness of Query event parallelization when
> +# a DML Query modifies multiple databases.
> +#
> +
> +--source include/master-slave.inc
> +--source include/have_binlog_format_statement.inc
> +
> +--disable_query_log
> +call mtr.add_suppression('.*Unsafe statement written to the binary log using
> statement format since BINLOG_FORMAT = STATEMENT.*');

Just a minor comment. This will work but you don't have to use a
regexp in add_suppression which covers the entire line. So .* at the
start and end here are superflous.

If the message is very long I often reduce it to what I presume to be
unique.

No need to re-commit just for this little thing of course. :-)

- Bjorn
Thread
bzr commit into mysql-next-mr-wl5569 branch (andrei.elkin:3271) WL#5754Andrei Elkin3 Feb
  • Re: bzr commit into mysql-next-mr-wl5569 branch(andrei.elkin:3271) WL#5754Bjorn Munch3 Feb