List:Commits« Previous MessageNext Message »
From:Dmitry Lenev Date:February 2 2011 4:23pm
Subject:Re: bzr commit into mysql-5.0 branch (Georgi.Kodinov:2899)
Bug#52315 Bug#55755
View as plain text  
Hello Joro!

* Georgi Kodinov <Georgi.Kodinov@stripped> [11/02/02 19:12]:
> #At file:///Users/kgeorge/mysql/work/B55755-5.0/ based on
> revid:ramil@stripped
> 
>  2899 Georgi Kodinov	2011-02-02
>       Fixes for Bug #55755 and Bug #52315 part 2
>       
>       Bug #55755 : Date STD variable signness breaks server on FreeBSD and OpenBSD
>       
>       * Added a check to configure on the size of time_t
>       * Created a macro to check for a valid time_t that is safe to use with datetime
> 
>         functions and store in TIMESTAMP columns.
>       * Used the macro consistently instead of the ad-hoc checks introduced by 52315
>       * Fixed compliation warnings on platforms where the size of time_t is smaller
> than
>         the size of a long (e.g. OpenBSD 4.8 64 amd64).
>       
>       Bug #52315: utc_date() crashes when system time > year 2037
>       
>       * Added a correct check for the timestamp range instead of just variable size
> check to
>       SET TIMESTAMP.
>       * Added overflow checking before converting to time_t. 
>       * Using a correct localized error message in this case instead of the generic
> error.
>       * Added a test suite.
>       * fixed the checks so that they check for unsigned time_t as well. Used the
> checks 
>         consistently across the source code.

I think it is OK to push this patch.

-- 
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com

Are you MySQL certified?  http://www.mysql.com/certification
Thread
bzr commit into mysql-5.0 branch (Georgi.Kodinov:2899) Bug#52315 Bug#55755Georgi Kodinov2 Feb
  • Re: bzr commit into mysql-5.0 branch (Georgi.Kodinov:2899)Bug#52315 Bug#55755Dmitry Lenev2 Feb