bk commit into 4.1 tree (iggy:1.2542) BUG#19660

[Ignacio Galarza]

Below is the list of changes that have just been committed into a local
4.1 repository of iggy. When iggy does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-10-03 11:26:50-04:00, iggy@stripped +1 -0
  Bug#19660 mysqldump --single-transaction should be with CONSISTENT SNAPSHOT

  client/mysqldump.c@stripped, 2006-10-03 11:26:47-04:00, iggy@stripped +3
-5
    Bug#19660 mysqldump --single-transaction should be with CONSISTENT SNAPSHOT
    
    - Remove old BEGIN syntax and replace with START TRANSATION. Add CONSISTENT SNAPSHOT
option for servers that support it.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	iggy
# Host:	rolltop.ignatz42.dyndns.org
# Root:	/mnt/storeage/bug19660/my41-bug19660

--- 1.200/client/mysqldump.c	2006-10-03 11:26:54 -04:00
+++ 1.201/client/mysqldump.c	2006-10-03 11:26:54 -04:00
@@ -2407,7 +2407,7 @@
 }
 
 
-static int start_transaction(MYSQL *mysql_con, my_bool consistent_read_now)
+static int start_transaction(MYSQL *mysql_con)
 {
   /*
     We use BEGIN for old servers. --single-transaction --master-data will fail
@@ -2422,10 +2422,8 @@
                                         "SET SESSION TRANSACTION ISOLATION "
                                         "LEVEL REPEATABLE READ") ||
           mysql_query_with_error_report(mysql_con, 0,
-                                        consistent_read_now ?
                                         "START TRANSACTION "
-                                        "WITH CONSISTENT SNAPSHOT" :
-                                        "BEGIN"));
+                                        "/*!40100 WITH CONSISTENT SNAPSHOT */"));
 }
 
 
@@ -2652,7 +2650,7 @@
   if ((opt_lock_all_tables || opt_master_data) &&
       do_flush_tables_read_lock(sock))
     goto err;
-  if (opt_single_transaction && start_transaction(sock, test(opt_master_data)))
+  if (opt_single_transaction && start_transaction(sock))
       goto err;
   if (opt_delete_master_logs && do_reset_master(sock))
     goto err;