Hello,
On 01/20/2011 12:48 PM, Tatiana Azundris Nurnberg wrote:
> #At file:///Users/tnurnberg/forest/48388/55-48388/ based on
> revid:dao-gang.qu@stripped
Looks like you've made the patch for 5.5?
I've checked with Staale and it should go to trunk.
> 3229 Tatiana Azundris Nurnberg 2011-01-20
> Bug#48388: additional logging for shutting down threads
I get a test error from mysqld--help-not-win.test when applying your
patch. I haven't tested, but I'm guessing mysqld--help-win.test will
also fail. Could you look into it?
> === modified file 'sql/mysqld.cc'
> --- a/sql/mysqld.cc 2010-12-29 00:26:31 +0000
> +++ b/sql/mysqld.cc 2011-01-20 11:47:44 +0000
> @@ -1073,6 +1073,8 @@ static void close_connections(void)
> statements and inform their clients that the server is about to die.
> */
>
> + sql_print_information("giving client threads a chance to die gracefully");
I'd suggest capitalizing this notice (as well as the other notices you
added to mysqld.cc) to make them similar to existing notices.
> @@ -1416,6 +1421,7 @@ void clean_up(bool print_message)
> make sure that handlers finish up
> what they have that is dependent on the binlog
> */
> + sql_print_information("binlog end");
I guess I can see the point of adding this notice even if it wasn't part
of the original feature request as far as I can see. Has there been a
discussion somewhere about adding additional notices?
> === modified file 'sql/sql_plugin.cc'
> --- a/sql/sql_plugin.cc 2010-12-02 07:16:26 +0000
> +++ b/sql/sql_plugin.cc 2011-01-20 11:47:44 +0000
> @@ -957,7 +957,10 @@ static void reap_plugins(void)
>
> list= reap;
> while ((plugin= *(--list)))
> + {
> + sql_print_information("Shutting down plugin '%s'", plugin->name.str);
> plugin_deinitialize(plugin, true);
> + }
Same comment here as for "binlog end".
--- Jon Olav
