#At file:///home/msvensson/mysql/5.5-telco-7.0/ based on revid:magnus.blaudd@strippeddg4tv
3168 Magnus Blåudd 2011-02-02
ndb
- remove code for which supports runing without --ndb-log-empty-epoch
- injector::rollback now supporte in 5.5-telco-7.0 and trunk
modified:
sql/ha_ndbcluster.cc
sql/ha_ndbcluster_binlog.cc
sql/ha_ndbcluster_glue.h
=== modified file 'sql/ha_ndbcluster.cc'
--- a/sql/ha_ndbcluster.cc 2011-02-01 14:58:18 +0000
+++ b/sql/ha_ndbcluster.cc 2011-02-02 08:07:45 +0000
@@ -14956,23 +14956,16 @@ static MYSQL_SYSVAR_BOOL(
1 /* default */
);
-#ifndef NDB_NO_LOG_EMPTY_EPOCHS
-#define LOG_EMPTY_EPOCHS_OPTS PLUGIN_VAR_OPCMDARG
-#define LOG_EMPTY_EPOCHS_DEFAULT 0
-#else
-#define LOG_EMPTY_EPOCHS_OPTS PLUGIN_VAR_OPCMDARG | PLUGIN_VAR_READONLY
-#define LOG_EMPTY_EPOCHS_DEFAULT 1
-#endif
static my_bool opt_ndb_log_empty_epochs;
static MYSQL_SYSVAR_BOOL(
log_empty_epochs, /* name */
opt_ndb_log_empty_epochs, /* var */
- LOG_EMPTY_EPOCHS_OPTS,
+ PLUGIN_VAR_OPCMDARG,
"",
NULL, /* check func. */
NULL, /* update func. */
- LOG_EMPTY_EPOCHS_DEFAULT /* default */
+ 0 /* default */
);
bool ndb_log_empty_epochs(void)
=== modified file 'sql/ha_ndbcluster_binlog.cc'
--- a/sql/ha_ndbcluster_binlog.cc 2011-01-31 08:20:49 +0000
+++ b/sql/ha_ndbcluster_binlog.cc 2011-02-02 08:07:45 +0000
@@ -6693,7 +6693,6 @@ restart_cluster_failure:
(! (opt_ndb_log_apply_status &&
trans_slave_row_count) ))
{
-#ifndef NDB_NO_LOG_EMPTY_EPOCHS
/* nothing to commit, rollback instead */
if (int r= trans.rollback())
{
@@ -6703,9 +6702,6 @@ restart_cluster_failure:
/* TODO: Further handling? */
}
break;
-#else
- abort(); // Should not come here, log-empty-epochs is always on
-#endif
}
}
commit_to_binlog:
=== modified file 'sql/ha_ndbcluster_glue.h'
--- a/sql/ha_ndbcluster_glue.h 2011-01-27 13:25:19 +0000
+++ b/sql/ha_ndbcluster_glue.h 2011-02-02 08:07:45 +0000
@@ -94,9 +94,6 @@ enum column_format_type {
/* Global schema lock not available */
#define NDB_NO_GLOBAL_SCHEMA_LOCK
-/* Missing functionality in injector -> no --ndb-log-empty-epochs */
-#define NDB_NO_LOG_EMPTY_EPOCHS
-
/*
The enum open_table_mode has been removed in 5.5.7 and 'open_table_from_share'
now takes "bool is_create_table" instead of the enum type. Define OTM_OPEN
Attachment: [text/bzr-bundle] bzr/magnus.blaudd@oracle.com-20110202080745-p4lidexmdocfuqiz.bundle
| Thread |
|---|
| • bzr commit into mysql-5.5-telco-7.0 branch (magnus.blaudd:3168) | Magnus Blåudd | 2 Feb |