List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:February 1 2011 8:43am
Subject:Re: bzr commit into mysql-5.1-telco-6.2 branch (Martin.Skold:3143)
Bug#57437
View as plain text  
Hi Martin,

a question below.

On Tue, Jan 25, 2011 at 10:45:50AM +0100, Martin Skold wrote:
> #At file:///home/marty/MySQL/mysql-5.1-telco-6.2_merge/
> 
>  3143 Martin Skold	2011-01-25
>       Bug#57437 CREATE TEMPORARY TABLE LIKE with ENGINE=NDBCluster causes mysqld
> crash?: Catch attempt to define temporary table in create method and return error

...skip...

> === modified file 'sql/sql_table.cc'
> --- a/sql/sql_table.cc	2010-10-06 10:06:47 +0000
> +++ b/sql/sql_table.cc	2011-01-25 09:45:42 +0000
> @@ -5399,9 +5399,9 @@ bool mysql_create_like_table(THD* thd, T
>    err= ha_create_table(thd, dst_path, db, table_name, create_info, 1);
>    VOID(pthread_mutex_unlock(&LOCK_open));
>  
> -  if (create_info->options & HA_LEX_CREATE_TMP_TABLE)
> +  if (!err && create_info->options & HA_LEX_CREATE_TMP_TABLE)
>    {
> -    if (err || !open_temporary_table(thd, dst_path, db, table_name, 1,
> +    if (!open_temporary_table(thd, dst_path, db, table_name, 1,
>                                       OTM_OPEN))
>      {
>        (void) rm_temporary_table(create_info->db_type,
Hmm... afaics dot-frm for a new table is created at this point. But
not removed on error. Is there a dot-frm leak?

Regards,
Sergey
-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.1-telco-6.2 branch (Martin.Skold:3143) Bug#57437Martin Skold25 Jan
  • Re: bzr commit into mysql-5.1-telco-6.2 branch (Martin.Skold:3143)Bug#57437Magnus BlĂ„udd25 Jan
  • Re: bzr commit into mysql-5.1-telco-6.2 branch (Martin.Skold:3143)Bug#57437Sergey Vojtovich1 Feb